HLTTauDQM: ignoring modules starting with '-' (modules inside cms.ign…

[slehti]

New DeepTau paths contain modules inside cms.ignore(). This caused problems with the offline object matching, HLTTauDQM stopped when not finding offline muons for di-tau path (inside ignore there are all L1 seeds including mu+tau seed, therefore the code is looking for muons, too).
Fix: ignore all modules inside cms.ignore(): i.e. modules starting with a '-'.

Files changed: DQMOffline/Trigger/src/HLTTauDQMPath.cc

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36560/27504

• This PR adds an extra 16KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36560/27504/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36560/27504/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36560/27505

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slehti for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@sscruz, @missirol, @mtosi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1fc82/21415/summary.html
COMMIT: 9f15019
CMSSW: CMSSW_12_3_X_2021-12-20-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36560/21415/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3461688
• DQMHistoTests: Total failures: 11
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3461654
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -9.004 KiB( 42 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): -1.500 KiB HLT/TAU
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

Aren't there modules with a "-" somewhere in the name? Wouldn't it be safer to check that they just don't start with a "-"?
(perhaps @cms-sw/hlt-l2 could remind me if a "-" in the name is just forbidden for hlt modules, in which case the proposed syntax is ok)

[missirol]

Hi @perrotta

Wouldn't it be safer to check that they just don't start with a "-"?

I think that's what this check is doing: it checks if character - is at position 0 using find, and if so it skips the word.

Aren't there modules with a "-" somewhere in the name?

If you mean a - somewhere in the middle of the module name/label, as far as I know that's not possible for any module, not just HLT (that works for _, of course, but not for other special characters like -).

[perrotta]

+1