Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLTTauDQM: ignoring modules starting with '-' (modules inside cms.ign… #36560

Merged
merged 2 commits into from Dec 24, 2021
Merged

HLTTauDQM: ignoring modules starting with '-' (modules inside cms.ign… #36560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2d50ae
HLTTauDQM: ignoring modules starting with '-' (modules inside cms.ign…
slehti Dec 21, 2021
9f15019
HLTTauDQMPath code-format
slehti Dec 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions DQMOffline/Trigger/src/HLTTauDQMPath.cc
View file
Open in desktop
Expand Up @@ -54,6 +54,8 @@ namespace {
continue;
if (type == "HLTTriggerTypeFilter" || type == "HLTBool")
continue;
if (iLabel->find('-') == 0) // ignore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't there modules with a "-" somewhere in the name? Wouldn't it be safer to check that they just don't start with a "-"?
(perhaps @cms-sw/hlt-l2 could remind me if a "-" in the name is just forbidden for hlt modules, in which case the proposed syntax is ok)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @perrotta

Wouldn't it be safer to check that they just don't start with a "-"?

I think that's what this check is doing: it checks if character - is at position 0 using find, and if so it skips the word.

Aren't there modules with a "-" somewhere in the name?

If you mean a - somewhere in the middle of the module name/label, as far as I know that's not possible for any module, not just HLT (that works for _, of course, but not for other special characters like -).

continue;
if (type == "HLT2PhotonPFTau" || type == "HLT2ElectronPFTau" || type == "HLT2MuonPFTau" ||
type == "HLT2PhotonTau" || type == "HLT2ElectronTau" || type == "HLT2MuonTau")
leptonTauFilters.emplace_back(*iLabel);
Expand Down