Run3-gex108x Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in the forrward region (BHM, PLT, BCMF) plus removing BSC

[bsunanda]

PR description:

Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in the forrward region (BHM, PLT, BCMF) plus removing BSC. To make it to work, need to merge several PR's: #36652, #36653 and the relevant PR's from the GEM group fixing creation of RECO geometry and DQM for GE21 demonstration chamber

PR validation:

To be tested when all those PR's are merged to the master. Tested in some standalone way

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36654/27679

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

• Configuration/Geometry (geometry, upgrade)
• Geometry/CMSCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

Hi @bsunanda
Could you please provide more detail on why we modify the existing Run-3 geometry without creating the new one? I assume the one in GT is still be the one we use for production, but should XML reflect the same geometry? I would avoid merging piece-by-piece PR without a full picture. Thanks.

[civanch]

@srimanob , we discussed the situation at the last SIM meeting: https://indico.cern.ch/event/1105846/contributions/4652380/attachments/2367389/4042705/Sim-Talk137.pdf

There are several minor modifications, which should not affect particle flow calibration but require fixes.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36654/27842

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #36654 was updated. @civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

[qliphy]

urgent
as discussed at yesterday's ORP, pre4 will include this PR together with #36715 to make a comparison with pre3.

[qliphy]

please test

[perrotta]

please test with #36755,#36679,#36750,#36765,#36766
(test the whole set together)

[srimanob]

If the test is OK and geometry signs, please feel free to merge if you need it by today. I will check and sign tomorrow morning. Thanks.

[cvuosalo]

Geometry will sign after the test results come in OK.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc1c0/21904/summary.html
COMMIT: adb262d
CMSSW: CMSSW_12_3_X_2022-01-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36654/21904/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 20151 differences found in the comparisons
• DQMHistoTests: Total files compared: 43
• DQMHistoTests: Total histograms compared: 3464860
• DQMHistoTests: Total failures: 115333
• DQMHistoTests: Total nulls: 28
• DQMHistoTests: Total successes: 3349477
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1882.468 KiB( 42 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 131.874 KiB RPC/AllHits
• DQMHistoSizes: changed ( 11634.0,... ): 131.728 KiB RPC/Muon
• DQMHistoSizes: changed ( 11634.0,... ): 0.078 KiB RPC/RPCRecHitV
• DQMHistoSizes: changed ( 11634.911 ): 33.682 KiB GEM/Efficiency
• DQMHistoSizes: changed ( 11634.911 ): 1.448 KiB GEM/Digis
• DQMHistoSizes: changed ( 11634.911 ): 0.614 KiB GEM/SimHits
• DQMHistoSizes: changed ( 11634.911 ): 0.531 KiB GEM/Pad
• DQMHistoSizes: changed ( 11634.911 ): 0.432 KiB GEM/PadCluster
• DQMHistoSizes: changed ( 11634.911 ): 0.299 KiB GEM/RecHits
• DQMHistoSizes: changed ( 11834.0 ): -0.298 KiB SiStrip/MechanicalView
• Checked 181 log files, 42 edm output root files, 43 DQM output files
• TriggerResults: found differences in 6 / 42 workflows

[cvuosalo]

+1

[cvuosalo]

Test results are as expected for the change in the Run 3 geometry.

[perrotta]

+1

• Merging together Run3-gex112X Correction to the MuonOffsets for the new Run3 scenario (due to Ian) #36679 Run3-gex108x Modify all Run3 geometry scenarios by including demonstration chambers of GE21 & RPC, and detectors in the forrward region (BHM, PLT, BCMF) plus removing BSC #36654 Run3-gex112Y Make the default creation of Simhits for Demo chambers to be true as required by the respective DPG's #36750 Turn off warnings for missing chamber in GEM GE2/1 demonstrator geometry #36765 Update final Run3 MC geometry (reprise) #36766 for pre4

[perrotta]

merge

[srimanob]

+Upgrade

This PR changes the dict2021 geometry configuration. Changes are expected on all Run-3 workflows in the short matrix. PR test runs fine and gets expected results.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing).