Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPS renaming AlCa Prompt producers and PPSCalTrackBasedSel AlCa Reco to autoAlca.py #36702

Merged
merged 6 commits into from Jan 22, 2022

Conversation

grzanka
Copy link
Contributor

@grzanka grzanka commented Jan 13, 2022

PR description:

This PR is a refactoring (renaming) of the AlCa Prompt producers responsible for PPS Timing Calibration.
It resolves cms-AlCaDB/AlCaTools#53

The changes are necessary for T0 replay with PPS. The suggestions for renaming appeared in the discussion of #36273
It is following #36698

This PR initially contained refactoring of PPS timing calibration producers (hence the branch name CTPPS:pps_timing_calibration_tier0_renaming).
As suggested in #36702 (comment)
I've merged here as well commits from other PRs:

PR validation:

Tested with:

runTheMatrix.py -l 1041 --ibeos
runTheMatrix.py -l 1042 --ibeos

@cmsbuild cmsbuild added this to the CMSSW_12_3_X milestone Jan 13, 2022
@grzanka
Copy link
Contributor Author

grzanka commented Jan 13, 2022

@malbouis @tvami FYI

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36702/27778

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @grzanka (Leszek Grzanka) for master.

It involves the following packages:

  • CalibPPS/TimingCalibration (alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @malbouis, @yuanchao, @jordan-martins, @bbilin, @wajidalikhan, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @fabferro, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @tocheng, @lecriste, @mmusich, @slomeo, @mtosi, @dgulhan, @kpedro88 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@yuanchao
Copy link
Contributor

@cmsbuild please test

@yuanchao
Copy link
Contributor

@cmsbuild please abort

@yuanchao
Copy link
Contributor

test parameters:

workflows=1042

@yuanchao
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a7ada/21718/summary.html
COMMIT: 223b0be
CMSSW: CMSSW_12_3_X_2022-01-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36702/21718/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9a7ada/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3461659
  • DQMHistoTests: Total failures: 12
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3461625
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jan 21, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9a7ada/21910/summary.html
COMMIT: 6c00348
CMSSW: CMSSW_12_3_X_2022-01-21-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36702/21910/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-9a7ada/1042.0_RunExpressPhy2017F+RunExpressPhy2017F+TIER0EXPPPSCALALIG+ALCASPLITPPSALIG+ALCAHARVDPPSALIG

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 43
  • DQMHistoTests: Total histograms compared: 3464860
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3464832
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 42 files compared)
  • Checked 181 log files, 42 edm output root files, 43 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jan 22, 2022

+1

  • tests pass except for the known issues
  • the PR is techincal, just renames files so that T0 can recognize them

@tvami
Copy link
Contributor

tvami commented Jan 22, 2022

Hi @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 please consider signing it again, there was nothing changed from what you already signed earlier

@srimanob
Copy link
Contributor

+Upgrade

Technical PR on renaming of PPS Timing Calibration alca prompt producer. PR test runs fine.

@kskovpen
Copy link
Contributor

+1

@tvami
Copy link
Contributor

tvami commented Jan 22, 2022

Hi @perrotta @qliphy this is essentially fully signed now, let's merge it and then have a backport to 12_2_X

@perrotta
Copy link
Contributor

+operations

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename PPS ALCARECOs
9 participants