Backport to 12_2_X: ECAL TPG Parameter Builder changes for double weights

[valsdav]

This is a backport of PR #36446 needed to propagate the changes to the CMSSW version currently available for tests in P5.

PR description:

The ECALTPGParamBuilder code computes the parameters for the ECAL Trigger Primitives (TP) configuration, including pedestals, weights and transparency calibrations.
This PR introduces the necessary changes to include the double weights configuration in the configuration scripts.
Moreover the code has been revised to include some additional cross-checks for problematic crystals. The weights configuration can be now read from files and not only computed from the pulse shapes.

The necessary OnlineDB, CondDB and trigger emulator changes for the double weights mechanism have been already included in previous PRs : #33220, #33349, #33748

PR validation:

The full chain of ECAL TP configuration has been tested during the extended MWGR in November. The BEAMV7 key has been created in the OnlineDB by the configuration script and tested in global run.
A description of the double weight mechanism and related DB classes has been given at the Alca meeting and can be found here: https://indico.cern.ch/event/1020767/#16-new-ecal-tpg-db-classes-for

[cmsbuild]

A new Pull Request was created by @valsdav (Davide Valsecchi) for CMSSW_12_2_X.

It involves the following packages:

• CalibCalorimetry/EcalTPGTools (l1, alca)
• OnlineDB/EcalCondDB (db)
• SimCalorimetry/EcalTrigPrimProducers (l1)

@malbouis, @yuanchao, @epalencia, @cmsbuild, @rekovic, @ggovi, @tvami, @cecilecaillol, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @rovere, @argiro, @tocheng, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from ECAL TPG Parameter Builder changes for double weights mechanism #36446

[valsdav]

backport of #36446

[francescobrivio]

backport of #36446

[francescobrivio]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9d6e59/21852/summary.html
COMMIT: f5f411d
CMSSW: CMSSW_12_2_X_2022-01-20-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36760/21852/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 4.764.76_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT/step2_ZMuSkim2012D+ZMuSkim2012D+HLTDSKIM2+RECODR1reHLT2+HARVESTDR1reHLT.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 42
• DQMHistoTests: Total histograms compared: 3250594
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3250572
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
• Checked 177 log files, 37 edm output root files, 42 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+1

• backport of ECAL TPG Parameter Builder changes for double weights mechanism #36446
• all tests pass except for the known issue with 4.76

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[tvami]

Hi @valsdav can you please include the string "12_2_X" in the PR title to see where this is a backport to?

[tvami]

Also @valsdav is this relevant for Cosmics? 12_2 is only to be used for Feb cosmics, so I'm not sure we really need this backport at all

[valsdav]

Also @valsdav is this relevant for Cosmics? 12_2 is only to be used for Feb cosmics, so I'm not sure we really need this backport at all

Hi @tvami, this is needed indeed to be able to test the ECAL Trigger configuration setup in P5 during the Cosmics run in February.

[qliphy]

merge