Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.2.X] Improvements on SiPixelLorentzAngle PCL workflow: layer-dependent cluster size cut and output maps #36866

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Feb 2, 2022

backport of #36853

PR description:

This PR collects a series of improvements coming from the commissioning of the SiPixelLorentzAngle PCL workflow being commissioned at dmwm/T0#4635 and builds on top of PRs #36565 and #36538:

  • adds output LorentzAngle maps to SiPixelLorentzAnglePCLHarvester (507cc26 and 246ef92)
  • layer-dependent cluster y-size cut in SiPixelLorentzAnglePCLWorker (2e02258)
  • add SiPixelLorentzAngleFullMapCompare to Pixel Payload Inspector (dbb5a2d), triggers also DQM signature

PR validation:

Privately run

 cmsDriver.py testReAlCa -s ALCA:PromptCalibProdSiPixelLorentzAngle --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --datatier ALCARECO --eventcontent ALCARECO --processName=ReAlCa -n 100000 --dasquery='file dataset=/StreamExpress/Tier0_REPLAY_2021-SiPixelCalSingleMuon-Express-v1/ALCARECO' --customise_commands='process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.TriggerResultsTag = cms.InputTag ( "TriggerResults","","HLT" ) ; process.ALCARECOCalSignleMuonFilterForSiPixelLorentzAngle.HLTPaths = ["*"]' --nThreads=4 

followed by:

 cmsDriver.py stepHarvest -s ALCAHARVEST:SiPixelLA --conditions 121X_dataRun3_Express_TIER0_REPLAY_Run2_v1 --scenario pp --data --era Run2_2018 --filein file:PromptCalibProdSiPixelLorentzAngle.root -n -1

For what concerns the PI update (dbb5a2d), here's an example of plot obtainable (using the results of the Tier-0 replay):

badaa251-0920-4125-a57a-99d80cf368f4

if this PR is a backport please specify the original PR and why you need to backport that PR:

Verbatim backport of #36853

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_2_X.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)
  • CondCore/SiPixelPlugins (db)
  • DQM/TrackerRemapper (dqm)

@malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@hdelanno, @tocheng, @VinInn, @OzAmram, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Feb 2, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-228a11/22167/summary.html
COMMIT: 246ef92
CMSSW: CMSSW_12_2_X_2022-02-02-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36866/22167/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3250594
  • DQMHistoTests: Total failures: 45
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3250526
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.385 KiB( 41 files compared)
  • DQMHistoSizes: changed ( 1001.0 ): 8.385 KiB AlCaReco/SiPixelLorentzAngleHarvesting
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 2, 2022

+1

  • changes as expected

@jfernan2
Copy link
Contributor

jfernan2 commented Feb 3, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2022

+1

  • Identical to the backported PR, already successfully merged in the master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants