Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable D88 PU wfs #36871

Merged
merged 4 commits into from Feb 7, 2022
Merged

Disable D88 PU wfs #36871

merged 4 commits into from Feb 7, 2022

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Feb 3, 2022

PR description:

This PR is to fix IB issue of D88 PU wfs, #36833 (comment)
In addition, this PR also disable D88 dd4hep wf, and update README.

PR validation:

  • Test with 39434.21,39634.21,39634.9921,39634.99,39634.999

if this PR is a backport please specify the original PR and why you need to backport that PR:

  • No need of backport.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36871/28130

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Feb 3, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1902b4/22177/summary.html
COMMIT: e1f31ef
CMSSW: CMSSW_12_3_X_2022-02-02-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36871/22177/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1902b4/39434.0_TTbar_14TeV+2026D88+TTbar_14TeV_TuneCP5_GenSimHLBeamSpot14+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1902b4/39496.0_CloseByPGun_CE_E_Front_120um+2026D88+CE_E_Front_120um_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-1902b4/39500.0_CloseByPGun_CE_H_Coarse_Scint+2026D88+CE_H_Coarse_Scint_GenSimHLBeamSpotHGCALCloseBy+DigiTrigger+RecoGlobal+HARVESTGlobal

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3765022
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3764992
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Feb 3, 2022

+Upgrade

This PR is to disable D88 PU workflows until the migration is complete.

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2022

@cms-sw/pdmv-l2 do you agree in temporarily disabling the D88 PU wfs, thus avoiding the errors in the IB tests until minbias events for the PU can be produced in pre5?

@kskovpen
Copy link
Contributor

kskovpen commented Feb 3, 2022

OK, so this would mean performing the D88 validation in noPU wfs in pre5 and, once D88 PU wfs are enabled in post-pre5 release, validate D88 once again (noPU and PU). This should be fine, unless @bbilin and @jordan-martins have a different opinion.

@srimanob
Copy link
Contributor Author

srimanob commented Feb 3, 2022

Hi @kskovpen
You can validate classical PU mixing in pre5 also. I just need an updated MinBias dataset, to define what will be used for MinBias in the short matrix and IB.

@srimanob
Copy link
Contributor Author

srimanob commented Feb 3, 2022

Or if needed, I can enable PU using 12_2_0_pre3 D88 for now, then update later.
/RelValMinBias_14TeV/CMSSW_12_2_0_pre3-122X_mcRun4_realistic_v4_2026D88noPU-v1/GEN-SIM
(maybe in PR that will not be merged, just to prove a thing is doing right)

@kskovpen
Copy link
Contributor

kskovpen commented Feb 4, 2022

Hi @kskovpen
You can validate classical PU mixing in pre5 also. I just need an updated MinBias dataset, to define what will be used for MinBias in the short matrix and IB.

OK, let's follow this way.

@srimanob
Copy link
Contributor Author

srimanob commented Feb 7, 2022

@cmsbuild please abort

@srimanob
Copy link
Contributor Author

srimanob commented Feb 7, 2022

test parameters:

@srimanob
Copy link
Contributor Author

srimanob commented Feb 7, 2022

@cmsbuild please test

@srimanob srimanob changed the title Fix D88 PU wfs Disable D88 PU wfs Feb 7, 2022
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1902b4/22253/summary.html
COMMIT: a287647
CMSSW: CMSSW_12_3_X_2022-02-06-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36871/22253/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 46
  • DQMHistoTests: Total histograms compared: 3766018
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3765988
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 45 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 193 log files, 42 edm output root files, 46 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Feb 7, 2022

+Upgrade

@srimanob
Copy link
Contributor Author

srimanob commented Feb 7, 2022

I think the PR is ready as we agreed @kskovpen

@kskovpen
Copy link
Contributor

kskovpen commented Feb 7, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Feb 7, 2022

+1

  • (To be re-enabed as soon as the minbias samples for PU will become available in pre5)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants