Add SV variables to BTV OfflineDQM

[marco-link]

PR description:

• add secondary vertex variables to @miniAODDQM (removed with deprecated module in Cleanup of BTV OfflineDQM #34156)
• fix discriminator distributions to match with pre-BTV OfflineDQM preparations for Run 3 #35985 distributions

Addition of SV variables presented in the Btag WG Meeting.

PR validation:

runTheMatrix.py -l 12034.0, used for validation plots to verify the fix of discriminator distributions.

runTheMatrix.py -l limited -i all

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36884/28147

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Adding muon MVA ID #36179

[cmsbuild]

A new Pull Request was created by @marco-link for master.

It involves the following packages:

• DQMOffline/RecoB (dqm)
• PhysicsTools/PatAlgos (reconstruction)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @slava77, @jpata, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@AlexDeMoor, @rappoccio, @gouskos, @jdolen, @JyothsnaKomaragiri, @ahinzmann, @schoef, @emilbols, @jdamgov, @mbluj, @nhanvtran, @gkasieczka, @hatakeyamak, @gpetruc, @azotz, @mariadalfonso, @demuller, @rociovilar, @andrzejnovak, @seemasharmafnal, @mmarionncern this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

Hi @marco-link
Before proceeding with this PR, is this PR related to the homework pending since last DQM Sequence review back in 2019:

https://indico.cern.ch/event/870363/contributions/3670597/attachments/1975300/3287456/BTV_DQM_Update_Final.pdf

It was agreed by then that, the old taggers SMT, SET, etc. could be removed from validation code for clean-up in code and memory.

Could this be performed now at some point?
There is a thread with subject "Clean up of DQM BTV" which apparently you have not answered since almost 1 year ago
Thanks

[marco-link]

Hi @jfernan2,
the old taggers have already been removed from the OfflineDQM/Validation by #34156.
Sorry if it was unclear that this also effects Validation.

This PR is a follow up to the cleanup in which I had to remove the SV variables because they were tied to an old tagger and were using a deprecated class.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3ce97/22222/summary.html
COMMIT: 74ee226
CMSSW: CMSSW_12_3_X_2022-02-03-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36884/22222/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 46
• DQMHistoTests: Total histograms compared: 3765022
• DQMHistoTests: Total failures: 9998
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3755001
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 50.884 KiB( 45 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 1.696 KiB Btag/SV
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 193 log files, 42 edm output root files, 46 DQM output files
• TriggerResults: no differences found

[jfernan2]

@marco-link apart from the 13 new MEs added, there are many MEs which change their content with this PR. I don't have the expertise to judge if the differences are significant and in the right direction, could you please have a look?
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_3_X_2022-02-03-2300+c3ce97/48223/dqm-histo-comparison-summary.html
Thanks

[marco-link]

@jfernan2 The differences except for the jet multiplicity are as expected. The new MEs look fine, too.
There was a misplaced bracket causing the jet multiplicity to be filled for each jet instead of once per event.
It should be fixed now.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36884/28197

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): [MiniAOD] Lower AK4 Puppi jets pT cut for Run 3 #36890, Adding muon MVA ID #36179

[cmsbuild]

Pull request #36884 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @slava77, @jpata, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36884/28758

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #36884 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please check and sign again.

[soureek]

@jpata Can you please start testing the latest changes?? We would like to have it integrated ASAP.

[jpata]

@soureek there are only DQM changes now, therefore I have not seen it in the reco list in the last weeks, and I have not commented on it.

@cms-sw/dqm-l2 can offer you a review and eventually sign.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c3ce97/23178/summary.html
COMMIT: 188ec48
CMSSW: CMSSW_12_4_X_2022-03-16-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/36884/23178/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695377
• DQMHistoTests: Total failures: 9518
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3685837
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 45.792 KiB( 48 files compared)
• DQMHistoSizes: changed ( 10024.0,... ): 1.696 KiB Btag/SV
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1