Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New trk driven seeding all pre7 #3690

Merged
merged 4 commits into from May 13, 2014

Conversation

dbenedet
Copy link
Contributor

@dbenedet dbenedet commented May 6, 2014

New trackerDriven seeding. Updated after 5 years.
This pull request requires new xml files that at present are in the usual afs area:
Related to the comments on this pull request:
#3678

I am not sure how the xml files need to be uploaded now.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 6, 2014

A new Pull Request was created by @dbenedet for CMSSW_7_1_X.

New trk driven seeding all pre7

It involves the following packages:

RecoParticleFlow/Configuration
RecoParticleFlow/PFTracking

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@bachtis, @lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@slava77
Copy link
Contributor

slava77 commented May 6, 2014

Hi Daniele,

Have you submitted a request for the files in cmsdist? (https://github.com/cms-sw/cmsdist/issues)
This is the channel to get the files to show up in the data external package containing these files.

@dbenedet
Copy link
Contributor Author

dbenedet commented May 6, 2014

Done:
cms-sw/cmsdist#651

@ghost
Copy link

ghost commented May 7, 2014

Hi, the files have been included in cms-sw/cmsdist#659.
They should appear with today afternoon IB (2014-05-07-1400).

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented May 8, 2014

@VinInn
Copy link
Contributor

VinInn commented May 9, 2014

since a change of PSet is required, one can take the opportunity to add the TRKBuilderName as PSet
and remove the hardcoded version at
https://github.com/dbenedet/cmssw/blob/newTrkDrivenSeeding_all_pre7/RecoParticleFlow/PFTracking/plugins/GoodSeedProducer.cc#L174
(different for RECO and HLT)

@slava77
Copy link
Contributor

slava77 commented May 9, 2014

Just reposting the link for performance (from #3678) : A bit more efficiency for the same fake rate:
https://indico.cern.ch/event/305108/contribution/1/material/slides/0.pdf

@slava77
Copy link
Contributor

slava77 commented May 13, 2014

+1

for #3690 af7dfbc

tested in CMSSW_7_1_X_2014-05-12-0200 (test area sign370).
There are more tracker-driven electrons (dijet QCD wf 38.0 has ~+20% tracker driven, increasing the total electrons by 10%)

pf candidates content didn't change much.

trackerDrivenElectronSeeds time up by 15 ms/evt in ttbar events (Run-1 MC, wf 202.0), this is about 0.2% of CPU. Most likely it's the 9 different weight files

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request May 13, 2014
@davidlange6 davidlange6 merged commit e0fb48e into cms-sw:CMSSW_7_1_X May 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants