Run3-alca216Y To make the response study work without HLT information if needed #36912

bsunanda · 2022-02-08T16:19:11Z

PR description:

To make the response study work without HLT information if needed

PR validation:

Used in the new validation of Geant4 package

if this PR is a backport please specify the original PR and why you need to backpaort that PR:

Nothing special

cmsbuild · 2022-02-08T16:25:37Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36912/28220

This PR adds an extra 20KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36912/28220/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36912/28220/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2022-02-08T16:47:03Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36912/28222

This PR adds an extra 20KB to repository

cmsbuild · 2022-02-08T16:47:28Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Calibration/IsolatedParticles (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2022-02-08T16:50:52Z

@cmsbuild Please test

tvami · 2022-02-08T16:57:08Z

Calibration/IsolatedParticles/plugins/StudyCaloResponse.cc

-        nPV = i;
-        break;
+    int ntrk(0), ngoodPV(0), nPV(-1), nvtxs(0);
+    if (!recVtxs.isValid()) {


Shouldnt you just not run this when there is no valid vertex? Give an exception or something?

cmsbuild · 2022-02-08T20:50:40Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62dd41/22290/summary.html
COMMIT: dd014e3
CMSSW: CMSSW_12_3_X_2022-02-08-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36912/22290/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3765080
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3765050
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

tvami · 2022-02-09T21:52:30Z

@cmsbuild , please test

bsunanda · 2022-02-10T14:24:11Z

@cmsbuild Please test

cmsbuild · 2022-02-10T14:30:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-36912/28250

This PR adds an extra 24KB to repository

cmsbuild · 2022-02-10T14:30:48Z

Pull request #36912 was updated. @malbouis, @tvami, @yuanchao, @francescobrivio can you please check and sign again.

cmsbuild · 2022-02-10T18:29:15Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-62dd41/22335/summary.html
COMMIT: 92bd73d
CMSSW: CMSSW_12_3_X_2022-02-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36912/22335/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 46
DQMHistoTests: Total histograms compared: 3764420
DQMHistoTests: Total failures: 8
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3764390
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 45 files compared)
Checked 193 log files, 42 edm output root files, 46 DQM output files
TriggerResults: no differences found

tvami · 2022-02-10T18:42:57Z

+alca

diffs in MsgLogger only

cmsbuild · 2022-02-10T18:43:21Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2022-02-11T01:31:11Z

+1

To make the response study work without HLT information if needed

6c3e39d

cmsbuild added this to the CMSSW_12_3_X milestone Feb 8, 2022

cmsbuild added alca-pending code-checks-pending orp-pending pending-signatures tests-pending labels Feb 8, 2022

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 8, 2022

Code check

dd014e3

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 8, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 8, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 8, 2022

tvami reviewed Feb 8, 2022

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Feb 8, 2022

Work only when get good vertex collection

dc2a1e5

cmsbuild added code-checks-pending tests-pending and removed tests-approved code-checks-approved labels Feb 9, 2022

cmsbuild added alca-pending code-checks-pending pending-signatures tests-pending and removed tests-started code-checks-rejected labels Feb 10, 2022

cmsbuild added tests-started and removed tests-pending labels Feb 10, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 10, 2022

cmsbuild added tests-approved and removed tests-started labels Feb 10, 2022

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Feb 10, 2022

cmsbuild added orp-approved and removed orp-pending labels Feb 11, 2022

cmsbuild merged commit 4ee2652 into cms-sw:master Feb 11, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Run3-alca216Y To make the response study work without HLT information if needed #36912

Run3-alca216Y To make the response study work without HLT information if needed #36912

bsunanda commented Feb 8, 2022

cmsbuild commented Feb 8, 2022

cmsbuild commented Feb 8, 2022

cmsbuild commented Feb 8, 2022

bsunanda commented Feb 8, 2022

tvami Feb 8, 2022

bsunanda Feb 9, 2022

cmsbuild commented Feb 8, 2022

tvami commented Feb 9, 2022

bsunanda commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

tvami commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

qliphy commented Feb 11, 2022

Run3-alca216Y To make the response study work without HLT information if needed #36912

Run3-alca216Y To make the response study work without HLT information if needed #36912

Conversation

bsunanda commented Feb 8, 2022

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backpaort that PR:

cmsbuild commented Feb 8, 2022

cmsbuild commented Feb 8, 2022

cmsbuild commented Feb 8, 2022

bsunanda commented Feb 8, 2022

tvami Feb 8, 2022

Choose a reason for hiding this comment

bsunanda Feb 9, 2022

Choose a reason for hiding this comment

cmsbuild commented Feb 8, 2022

Comparison Summary

tvami commented Feb 9, 2022

bsunanda commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

Comparison Summary

tvami commented Feb 10, 2022

cmsbuild commented Feb 10, 2022

qliphy commented Feb 11, 2022