Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[122X] Move ecal_dqm_sourceclient and hlt_dqm_sourceclient to Run-3 era #36947

Merged
merged 1 commit into from Feb 13, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Feb 12, 2022

PR description:

See #36946

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #36946

@tvami
Copy link
Contributor Author

tvami commented Feb 12, 2022

backport of #36946

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 12, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_2_X.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@battibass, @threus, @batinkov, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Feb 12, 2022

type bug-fix

@tvami
Copy link
Contributor Author

tvami commented Feb 12, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-373718/22377/summary.html
COMMIT: 010a57b
CMSSW: CMSSW_12_2_X_2022-02-12-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/36947/22377/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 42
  • DQMHistoTests: Total histograms compared: 3251294
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3251266
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 41 files compared)
  • Checked 177 log files, 37 edm output root files, 42 DQM output files
  • TriggerResults: no differences found

@jfernan2
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Succesfully merged in the master, it can enter the next (patch) release in 12_2 when needed

@cmsbuild cmsbuild merged commit 87c7bf9 into cms-sw:CMSSW_12_2_X Feb 13, 2022
@pmandrik
Copy link
Contributor

Dear @tvami ,

we have a following error when executing ecalcalib client config:

An exception of category 'NoRecord' occurred while
   [0] Processing global begin Run run: 347003
   [1] Prefetching for module EcalDQMonitorTask/'ecalMonitorTask'
   [2] Prefetching for EventSetup module CaloGeometryBuilder/''
   [3] Calling method for EventSetup module CastorGeometryFromDBEP/''
   [4] While getting dependent Record from Record CastorGeometryRecord
Exception Message:
No "PCastorRcd" record found in the EventSetup.

But it seems to works fine with a fix similare to one from this PR (also without the PR ecal client crashed with same error):

from Configuration.Eras.Era_Run3_cff import Run3
process = cms.Process("process", Run3)

Could you please check?

@tvami
Copy link
Contributor Author

tvami commented Feb 14, 2022

Hi @pmandrik sounds good, please submit a PR with that fix. I guess all the DQM configs should be revised @cms-sw/dqm-l2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants