Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MkFit] Fix uninitialized MkFinder::m_prop_config in backward-fit. #37038

Merged
merged 2 commits into from Feb 23, 2022
Merged

[MkFit] Fix uninitialized MkFinder::m_prop_config in backward-fit. #37038

merged 2 commits into from Feb 23, 2022

Commits on Feb 22, 2022

  1. Fix uninitialized MkFinder::m_prop_config in backward-fit. 

    - Introduce new MkFinder::setup_bkfit() function needed to setup
  local configuration pointers for backward-fit and use this
  in MkBuilder bk-fit steering function.
- Consistenly call MkFinder::release() from track finding steering
  code to re-initialize MkFinder configuration pointers to nullptr.
  This was effectively masking the issue of the missing setup call.
    @osschar
    osschar committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    d1f8ba5 View commit details
    Browse the repository at this point in the history

  2. code checks.

    @osschar
    osschar committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    2c35d3a View commit details
    Browse the repository at this point in the history