[MkFit] Fix uninitialized MkFinder::m_prop_config in backward-fit.

[osschar]

• Introduce new MkFinder::setup_bkfit() function needed to setup
  local configuration pointers for backward-fit and use this
  in MkBuilder bk-fit steering function.
• Consistenly call MkFinder::release() from track finding steering
  code to re-initialize MkFinder configuration pointers to nullptr.
  This was effectively masking the issue of the missing setup call.

This addresses #37017

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37038/28469

• This PR adds an extra 40KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37038/28469/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37038/28469/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37038/28471

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @osschar (Matevž Tadel) for master.

It involves the following packages:

• RecoTracker/MkFitCore (reconstruction)

@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @ebrondol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[smuzaffar]

Please test

[perrotta]

test parameters:

• workflows = 136.817,136.822,136.824,136.867

[perrotta]

please abort
(I am not sure if the extra workflows can be picked even if the "test parameters" command is issued after "please test")

[perrotta]

@cmsbuild please test
(Now they should...)

[slava77]

test parameters:

* workflows = 136.817,136.822,136.824,136.867

I think that workflow_threading is more appropriate here (assuming that I understood correctly that workflow_threading makes these workflows to run on multiple threads)

[qliphy]

please abort

[qliphy]

test parameters:

• enable_test = threading
• workflow_threading = 136.817,136.822,136.824,136.867
• workflows = 136.817,136.822,136.824,136.867

[qliphy]

please test

[qliphy]

type bugfix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-dce720/22599/summary.html
COMMIT: 2c35d3a
CMSSW: CMSSW_12_3_X_2022-02-22-2300/slc7_amd64_gcc10
Additional Tests: THREADING
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37038/22599/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce720/136.817_RunDoubleEG2017E+RunDoubleEG2017E+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017_skimDoubleEG
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce720/136.822_RunSingleEl2017E+RunSingleEl2017E+HLTDR2_2017+RECODR2_2017reHLT_Prompt_L1TEgDQM+HARVEST2017_L1TEgDQM
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce720/136.824_RunSinglePh2017E+RunSinglePh2017E+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017_skimSinglePh
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-dce720/136.867_RunSingleMu2018B+RunSingleMu2018B+HLTDR2_2018+RECODR2_2018reHLT_skimSingleMu_Offline_Lumi+HARVEST2018_L1TMuDQM

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 4001143
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 4001113
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[clacaputo]

+reconstruction

• bug fix for Crashes in mkfit::MkFinder::bkFitFitTracks() #37017
• test run on threading wf 136.817,136.822,136.824,136.867, they don't show any failures

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• To have it included in this night' IB