Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecation warnings from some CommonTools subsystems #37238

Merged
merged 5 commits into from Mar 17, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 14, 2022

PR description:

Technical, part of the migrations in #31061 and #36404.
Removed some of the CMSDEPRECATED_X warnings in the CommonTools subsystems from CMSSW_12_4_CMSDEPRECATED_X_2022-03-11-2300

PR validation:

cmssw compiles

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37238/28834

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • CommonTools/CandAlgos (reconstruction)
  • CommonTools/MVAUtils (reconstruction)
  • CommonTools/PileupAlgos (reconstruction)
  • CommonTools/TriggerUtils (hlt, l1)
  • CommonTools/UtilAlgos (reconstruction)

@Martin-Grunewald, @rekovic, @epalencia, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata, @cecilecaillol can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @missirol, @silviodonato, @ahinzmann, @gkasieczka, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 14, 2022

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c7887/23092/summary.html
COMMIT: 9166ab8
CMSSW: CMSSW_12_4_X_2022-03-13-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37238/23092/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695377
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695347
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37238/28867

  • This PR adds an extra 32KB to repository

@cmsbuild
Copy link
Contributor

Pull request #37238 was updated. @Martin-Grunewald, @rekovic, @epalencia, @clacaputo, @cmsbuild, @missirol, @slava77, @jpata, @cecilecaillol can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Mar 16, 2022

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3c7887/23153/summary.html
COMMIT: 8827314
CMSSW: CMSSW_12_4_X_2022-03-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37238/23153/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3695377
  • DQMHistoTests: Total failures: 5
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3695350
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

+hlt

@jpata
Copy link
Contributor

jpata commented Mar 17, 2022

+reconstruction

  • technical

@cecilecaillol
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants