-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate legacy EDModules to thread-efficient alternatives #36404
Comments
A new Issue was created by @makortel Matti Kortelainen. @Dr15Jones, @perrotta, @dpiparo, @makortel, @smuzaffar, @qliphy can you please review it and eventually sign/assign? Thanks. cms-bot commands are listed here |
assign analysis,code,db,dqm,generators,l1,upgrade (starting with categories whose legacy EDModules are being run in IBs) |
New categories assigned: upgrade,db,analysis,generators,l1,dqm @jfernan2,@ahmad3213,@AdrianoDee,@mkirsano,@rvenditti,@emanueleusai,@ggovi,@srimanob,@alberto-sanchez,@SiewYan,@santocch,@rekovic,@GurpreetSinghChahal,@francescobrivio,@pbo0,@malbouis,@tvami,@Saptaparna,@cecilecaillol,@agrohsje,@pmandrik you have been requested to review this Pull request/Issue and eventually sign? Thanks |
As a step towards being able to change the warning message to an exception (goal is by 13_0_0) I gathered EDModules listed by the warning messages in full runTheMatrix and unit test logs, and classified the EDModules by their packages and L2 areas. Below is a list from CMSSW_12_3_X_2021-12-06-2300 (the name(s) after the C++ type name are the module labels in the jobs they were run). @cms-sw/analysis-l2
@cms-sw/core-l2
@cms-sw/db-l2
@cms-sw/dqm-l2
@cms-sw/generators-l2
@cms-sw/l1-l2
@cms-sw/upgrade-l2
|
assign core |
New categories assigned: core @Dr15Jones,@smuzaffar,@makortel you have been requested to review this Pull request/Issue and eventually sign? Thanks |
Hi @SiewYan . Do you mind updating
|
@agrohsje , i will see to it! |
Thanks @makortel I found these two twikis but I am not sure if they are up to date: ecalPhysicsFilter |
@jfernan2 Those two links are largely up to date. In addition, the different module types (globla/stream/one) are documented in https://twiki.cern.ch/twiki/bin/view/CMSPublic/FWMultithreadedFrameworkModuleTypes and links in there. Some general rules of thumb
(there are many cases that do not fit in these categories, but I'd expect those to be easiest to discuss case-by-case) |
@jfernan2 Looking at the specific cases you listed
|
Around 2022-05-02 the deprecation annotations in CMSDEPRECATED_X were updated such that they should now flag reliably all classes that derive from legacy EDModule (or at least more reliably than earlier). I also went through the logs of CMSSW_12_5_X_2022-05-17-2300 matrix tests and unit tests, and the following legacy EDModules are being run there for sure (there can be more that my log parsing approach fails to find) @cms-sw/analysis-l2
@cms-sw/core-l2
@cms-sw/dqm-l2
Thanks for the help! The list continues to shrink. |
I updated the list of legacy EDModules still being run as part of runTheMatrix or unit tests for sure (there can be more that my log parsing approach fails to find) in CMSSW_12_6_X_2022-09-27-2300 Former @cms-sw/analysis-l2
@cms-sw/core-l2
@cms-sw/dqm-l2
|
I happen to do a tk offline shift this week and started to deal with
in #39518 |
For
@dzuolo can you fix this please? |
I'm working on these now:
|
I did EventFilter/LTCRawToDigi #39603 JetMETCorrections/Type1MET #39628 RecoHI/HiTracking #39654 RecoMuon/MuonIdentification RecoTBCalo/EcalTBHodoscopeReconstructor RecoTracker/DebugTools SimPPS/RPDigiProducer #39699 |
@cms-sw/dqm-l2 I suppose these modules could just be removed. When do you think that could be done? Could you take care of that? Thanks! |
ok I will take care of it this week |
Nothing yet, @francescobrivio do we have anybody else in the beamspot team who could do this? Simone maybe? I should also note @makortel that technically this is a |
Dear colleagues, |
Just did #39746 |
I just did L1Trigger/L1TMuonOverlap. I was just starting L1TriggerConfig, your comment was just in time. I'll do RecoJets/JetAnalyzers next. |
I know, but I replied to your (@tvami) comment in #36404 (comment). |
@emanueleusai These are now one of the few last legacy modules. Would you be able to take care of them soon? Or should we ( |
@emanueleusai Would you have any update when these modules could be removed (or otherwise be taken care of)? Or should we make an attempt? |
These are now migrated in #40409. |
Legacy EDModules have been effectively deprecated since the start of Run 2, and we are now phasing out their support.
Current ways to locate legacy EDModules:
test/
directoriescmsRun
jobs print out a warning message listing legacy EDModules run in that jobThe text was updated successfully, but these errors were encountered: