HCAL: fixing fine grain bits to be set based on unpacked TDC

[gk199]

PR description:

Changes are made in HcalFinegrainBits.cc to have both HB and HE fine grain bits set based on unpacked TDC. The fine grain bit algorithm relies on trigger primitives, which are prior to where the HB TDC packing (6:2 bit LUT) is performed. The 6:2 packing occurs in PackerHelp.h (tdc1 and tdc2 implemented in https://cmssdt.cern.ch/lxr/source/EventFilter/HcalRawToDigi/plugins/PackerHelp.h). With the change, HB and HE rely on the same logic, using tdc_boundary to compare to the TDC values.

Variable name tdc_HE was changed to tdc_boundary to be more clear. This encodes the prompt – delayed boundaries for both HB and HE.

Initial fine grain bit PR #34600 and #35599. L1 emulator PR (relies on the FG bits) #36919.

PR validation:

Tested in CMSSW_12_4_X_2022-03-21-1100. Passed runTheMatrix.py.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Will be backported to 12_3_X if possible, as this is relevant to Run 3 L1 trigger work.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37302/28941

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @gk199 (Gillian Kopp) for master.

It involves the following packages:

• SimCalorimetry/HcalTrigPrimAlgos (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@bsunanda, @abdoulline, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[epalencia]

Please test

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[cecilecaillol]

@perrotta, @dpiparo, @qliphy Do you know why the tests are still pending? The test command was issued 2 days ago.

[perrotta]

@perrotta, @dpiparo, @qliphy Do you know why the tests are still pending? The test command was issued 2 days ago.

@smuzaffar should we simply restart the tests, or is there anything blocking them that has to be fixed?

[smuzaffar]

please test
yes, if you do not see any bot activity and jenkins is not busy then feel free to restart any pr test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b6214c/23357/summary.html
COMMIT: 5475917
CMSSW: CMSSW_12_4_X_2022-03-24-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37302/23357/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 12 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695650
• DQMHistoTests: Total failures: 23
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3695604
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[perrotta]

Since the L1 signature was given before the test could finish, could anybody confirm that the test outputs are as expected, in particular the changes observed in the L1T HCAL DQM plots for the Run3 wf 11834 (and no changes in all other workflows)?

[gk199]

Changes in hcalOccSentFb2 are expected, due to the changes in setting fine grain bits 1,2, and 3 (zero indexing). hcalOccSentFb is filled here when t0().fineGrain(1) (fine grain bit 1 in SOI) is set. Due to the PR, fineGrain(1) will be set more often in HB, leading to DQM plot changes. Checked with HCAL DQM expert @lwang046.

[perrotta]

+1