update modifier to V16

[apsallid]

PR description:

With the latest RelVal campaign just announced (link) PdmV is moving rapidly to D88. In this PR we update the modifier in HGCalValidator to be able to correctly run on V16 HGCAL geometry scenario.

This should effect only the workflows that use the new V16 modifier, removing some empty histograms.

@rovere @felicepantaleo @pfs @ebrondol @lecriste

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37366/29020

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @apsallid for master.

It involves the following packages:

• Validation/HGCalValidation (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @pbo0, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @bsunanda, @pfs, @lecriste, @hatakeyamak, @ebrondol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58e8b2/23430/summary.html
COMMIT: 8689768
CMSSW: CMSSW_12_4_X_2022-03-27-0000/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37366/23430/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3583676
• DQMHistoTests: Total failures: 20137
• DQMHistoTests: Total nulls: 315
• DQMHistoTests: Total successes: 3563202
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -10108.403999999999 KiB( 47 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• DQMHistoSizes: changed ( 39434.0,... ): -2527.102 KiB HGCAL/HGCalValidator
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1