L1T vertex finder phase2 developments

[cecilecaillol]

PR description:

This is another PR to port all L1T Phase-2 developments to cms-sw. This PR targets the vertex finder code. It includes several PRs made locally, the details of which can be found in the twiki https://twiki.cern.ch/twiki/bin/view/CMSPublic/SWGuideL1TPhase2Instructions and in the cms-l1t-offline branch.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37382/29033

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @cecilecaillol for master.

It involves the following packages:

• L1Trigger/VertexFinder (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cecilecaillol]

please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d36cf/23453/summary.html
COMMIT: 85300fc
CMSSW: CMSSW_12_4_X_2022-03-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37382/23453/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37382/29035

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #37382 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[cecilecaillol]

please test

[cecilecaillol]

please test

[perrotta]

Thank you Cecile for taking my comments into account.
However, your update won't deal correctly with the case when maximum = -1 (and minimun is above it) from the parameter set.
A possible suggestion could be:

Suggested change

	if (maximum <= minimum) {
	maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05;
	minimum = float(*std::min_element(std::begin(data), std::end(data)));
	}
	if (minimum < 0) {
	minimum *= 1.05;
	} else {
	minimum = 0;
	}
	if (maximum == -1) {
	maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05;
	}
	if (maximum == -1) {
	maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05;
	}
	else if (maximum <= minimum) {
	maximum = float(*std::max_element(std::begin(data), std::end(data))) * 1.05;
	minimum = float(*std::min_element(std::begin(data), std::end(data)));
	}
	if (minimum < 0) {
	minimum *= 1.05;
	} else {
	minimum = 0;
	}

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37382/29120

• This PR adds an extra 48KB to repository

[cmsbuild]

Pull request #37382 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[cecilecaillol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d36cf/23590/summary.html
COMMIT: 2940b83
CMSSW: CMSSW_12_4_X_2022-03-31-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37382/23590/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3593039
• DQMHistoTests: Total failures: 14
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3593003
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 200 log files, 45 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[cecilecaillol]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1