New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update all GPU workflows #37411
Update all GPU workflows #37411
Conversation
2675a26
to
2ea647d
Compare
enable gpu |
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37411/29084
|
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages:
@jordan-martins, @bbilin, @wajidalikhan, @AdrianoDee, @srimanob, @kskovpen can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please wait before merging this PR, I will push some more developments |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0acc53/23527/summary.html GPU Comparison SummarySummary:
Comparison SummarySummary:
|
2ea647d
to
0ab5855
Compare
please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37411/29105
|
Pull request #37411 was updated. @jordan-martins, @bbilin, @wajidalikhan, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen can you please check and sign again. |
please test |
test parameters:
|
@smuzaffar , after this PR is merged, we could replace the GPU tests ( |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0acc53/23562/summary.html GPU Comparison Summary@slava77 comparisons for the following workflows were not done due to missing matrix map:
Summary:
Comparison SummarySummary:
|
+Upgrade This PR updates GPU workflows. |
@cms-sw/pdmv-l2, could you check this PR and let me know if you have any comments ? |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
urgent the backport should be in 12.3.0 |
10824.506, 10824.507, 10824.508, | ||
10824.512, 10824.513, 10824.514, | ||
10824.522, 10824.523, 10824.524, | ||
10824.582, 10824.583, # 10824.524, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: 10824.524 and 10824.528 here (and the same below at Ls 55-56) are just placeholders, isn't it?
To have the release numbers sequential in the tabs here, they should be 10824.584 and 10824.588 instead.
Note: I am NOT asking to modify anything here, just trying to understand the logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right, the placeholder comments have the wrong numbers :-/
+1 |
PR description:
Add Pixel-only and HCAL-only validation workflows:
#.503
(quadruplets),#.507
(triplets)#.523
Enable the existing Pixel-only and HCAL-only profiling workflows:
#.504
(quadruplets),#.508
(triplets)#.524
Add a single workflow running all GPU-enabled reconstruction (Pixel, ECAL, HCAL):
#.581
(quadruplets) and#.585
(triplets)#.582
(pixel quadruplets) and#.586
(triplets)#.583
(quadruplets) and#.587
(triplets)Do not customise the HLT, as it already makes full use of GPU reconstruction when the "gpu" modifier is enabled.
Add a short description before each workflow.
PR validation:
All new or updated GPU workflows ran successfully:
Pixel-only
ECAL-only
HCAL-only
All GPU sequences
Full offline reconstruction with all GPU sequences