Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X [12_4_X] #37594

Merged
merged 1 commit into from Apr 16, 2022

Conversation

missirol
Copy link
Contributor

PR description:

Development of HLT menus for CMSSW_12_3_X.

This is the PR for the master branch, which will then be backported to 12_3_X (which is currently the release used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2268: [MUO] Update of muon inside-out reco with pT-dependent Regions-Of-Interest.
  • CMSHLT-2269: [MUO] Update of muon outside-in track seeding with DNN.
  • CMSHLT-2277: [MUO] Renaming of old single-muon triggers.
  • CMSHLT-2279: [EXO] Update of LLP triggers (incl. change of L1T seeds).
  • CMSHLT-2283: [EXO] Fix to jet-timing producer in delayed-jet triggers.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37594/29355

  • This PR adds an extra 816KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9159cb/23968/summary.html
COMMIT: 84edd8f
CMSSW: CMSSW_12_4_X_2022-04-15-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37594/23968/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3591905
  • DQMHistoTests: Total failures: 2333
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3589550
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -882.3839999999999 KiB( 47 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): -115.890 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): -18.449 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 11634.0,... ): -12.760 KiB HLT/Muon
  • DQMHistoSizes: changed ( 11634.0,... ): 0.034 KiB HLT/Filters
  • Checked 200 log files, 45 edm output root files, 48 DQM output files
  • TriggerResults: found differences in 2 / 47 workflows

@missirol
Copy link
Contributor Author

+hlt

  • differences in outputs of Run-3 wfs are in line with changes to the HLT GRun menu.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 16, 2022

+1

@cmsbuild cmsbuild merged commit df4782b into cms-sw:master Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants