Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_3_X] Change regTrainedWithPS to true and update EGM HLT supercluster regression tags for Run 3 in MC #37625

Merged

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Apr 19, 2022

PR description:

See https://github.com/cms-sw/cmssw/pull/37588/commits

PR validation:

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #37588

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

test parameters:

  • workflows = 12034.0,11634.0,7.23,159.0,12434.0,12834.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/AlCa (alca)
  • RecoEcal/EgammaClusterAlgos (reconstruction)

@malbouis, @yuanchao, @clacaputo, @cmsbuild, @slava77, @jpata, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@Sam-Harper, @rchatter, @jainshilpi, @valsdav, @tocheng, @lgray, @Martin-Grunewald, @missirol, @sobhatta, @fabiocos, @thomreis, @afiqaize, @simonepigazzini, @wrtabb, @mmusich, @argiro, @varuns23, @ram1123 this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

Backport of #37588

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

assign hlt

@cmsbuild
Copy link
Contributor

New categories assigned: hlt

@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a69500/24023/summary.html
COMMIT: 99dc48e
CMSSW: CMSSW_12_3_X_2022-04-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37625/24023/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a69500/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-a69500/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4171871
  • DQMHistoTests: Total failures: 1515
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4170334
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 223 log files, 45 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 6 / 52 workflows

@tvami tvami force-pushed the EGM_HLTRegression_MC_Run3_Backport branch from 99dc48e to 623de85 Compare April 19, 2022 21:19
@cmsbuild
Copy link
Contributor

Pull request #37625 was updated. @malbouis, @yuanchao, @clacaputo, @cmsbuild, @missirol, @Martin-Grunewald, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

@tvami tvami force-pushed the EGM_HLTRegression_MC_Run3_Backport branch from 623de85 to d2d14c9 Compare April 19, 2022 21:20
@cmsbuild
Copy link
Contributor

Pull request #37625 was updated. @malbouis, @yuanchao, @clacaputo, @cmsbuild, @missirol, @Martin-Grunewald, @slava77, @jpata, @tvami, @francescobrivio can you please check and sign again.

@tvami
Copy link
Contributor Author

tvami commented Apr 19, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a69500/24032/summary.html
COMMIT: d2d14c9
CMSSW: CMSSW_12_3_X_2022-04-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37625/24032/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /pool/condor/dir_46348/jenkins/workspace/compare-root-files-short-matrix/data/PR-a69500/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /pool/condor/dir_46348/jenkins/workspace/compare-root-files-short-matrix/data/PR-a69500/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 53
  • DQMHistoTests: Total histograms compared: 4171871
  • DQMHistoTests: Total failures: 1521
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4170328
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 52 files compared)
  • Checked 223 log files, 45 edm output root files, 53 DQM output files
  • TriggerResults: found differences in 6 / 52 workflows

@francescobrivio
Copy link
Contributor

+alca

@missirol
Copy link
Contributor

+hlt

@tvami
Copy link
Contributor Author

tvami commented Apr 20, 2022

@clacaputo @jpata this PR is a verbatim backport of #37588 please consider signing it.

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 21, 2022

+1

@cmsbuild cmsbuild merged commit a0af05b into cms-sw:CMSSW_12_3_X Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants