Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add HLT-EGM customisation for 2018 Data [12_3_X] #37626

Merged
merged 1 commit into from Apr 20, 2022

Conversation

missirol
Copy link
Contributor

backport of #37606

PR description:

This PR updates the function customiseFor2018Input used by TSG to characterise the Run-3 HLT menu on 2018 collisions data.

It adds a function named customiseEGammaRecoFor2018Input, which currently sets the flag regTrainedWithPS to False to handle correctly the HLT-EGM energy regression tags of 2018.

#37625 (backport of #37588) changed the value of regTrainedWithPS to true for Run 3 via the source code. This PR updates the Run-2 customisation such that TSG studies using customiseFor2018Input are not affected by that update.

No changes expected. Note that PR tests are completely blind to the modifications in this PR.

PR validation:

Relies on the validation done for the original PR.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#37606

Maintenance of TSG recipes for HLT studies in 12_3_X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 19, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_3_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-30438d/24026/summary.html
COMMIT: cb9f39f
CMSSW: CMSSW_12_3_X_2022-04-19-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37626/24026/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3697135
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3697111
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 204 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Apr 20, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants