Remove unnecessary include of legacy EDAnalyzer header from HLTGenericFilter

[makortel]

PR description:

Identified as part of #37592.

PR validation:

Code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37709/29537

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

• HLTrigger/Egamma (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[cmsbuild]

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98c0bf/24271/summary.html
COMMIT: c036706
CMSSW: CMSSW_12_4_X_2022-04-27-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37709/24271/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 1000.0

----- Begin Fatal Exception 27-Apr-2022 18:34:12 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing input source of type PoolSource
   [2] Calling RootInputFileSequence::initTheFile()
   [3] Calling StorageFactory::open()
   [4] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root
      [b] Input file root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3014] Unable to open file  /eos/cms/store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root; Network is unreachable
' (errno=3014, code=400). No additional data servers were found.
      [d] Last URL tried: root://eoscms.cern.ch:1094//store/data/Run2011A/MinimumBias/RAW/v1/000/165/121/0699429A-B37F-E011-A57A-0019B9F72D71.root?tried=&xrdcl.requuid=189a965b-707a-4a98-93cf-7dbda6f59b85
      [e] Problematic data server: eoscms.cern.ch:1094
      [f] Disabled source: eoscms.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

• 312.0

----- Begin Fatal Exception 27-Apr-2022 18:34:41 CEST-----------------------
An exception of category 'FileOpenError' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'prevalidation_step'
   [2] Calling method for module MixingModule/'mix'
   [3] Calling RootInputFileSequence::initTheFile()
   [4] Calling StorageFactory::open()
   [5] Calling XrdFile::open()
Exception Message:
Failed to open the file 'root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root'
   Additional Info:
      [a] Calling RootInputFileSequence::initTheFile(): fail to open the file with name root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root
      [b] Input file root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root could not be opened.
      [c] XrdCl::File::Open(name='root://cms-xrd-global.cern.ch//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root', flags=0x10, permissions=0660) => error '[ERROR] Server responded with an error: [3014] Unable to open file  /eos/cms/store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root; Network is unreachable
' (errno=3014, code=400). No additional data servers were found.
      [d] Last URL tried: root://eoscms.cern.ch:1094//store/relval/CMSSW_12_1_0_pre4/RelValHydjetQ_B12_5020GeV_2021_ppReco/GEN-SIM/121X_mcRun3_2021_realistic_HI_v10-v1/10000/e2fc79c2-9ac7-4e01-af0c-85e4bee00bee.root?tried=&xrdcl.requuid=00f5fe23-a41f-4482-8a60-1733b174ced7
      [e] Problematic data server: eoscms.cern.ch:1094
      [f] Disabled source: eoscms.cern.ch:1094
----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

• 25.025.0_TTbar+TTbarINPUT+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbarINPUT+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log
• 26.026.0_WE+WEINPUT+DIGI+RECOAlCaCalo+HARVEST/step2_WE+WEINPUT+DIGI+RECOAlCaCalo+HARVEST.log
• 136.736136.736_RunHLTPhy2016C+RunHLTPhy2016C+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2/step2_RunHLTPhy2016C+RunHLTPhy2016C+HLTDR2_2016+RECODR2_2016reHLT_HIPM+HARVESTDR2.log

Expand to see more relval errors ...

• 136.738
• 136.735
• 136.739
• 136.737

[makortel]

@cmsbuild, please test

Failures look transient

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98c0bf/24316/summary.html
COMMIT: c036706
CMSSW: CMSSW_12_4_X_2022-04-27-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37709/24316/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695410
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1