Fix a bunch of clang reported issues.

[ktf]

No description provided.

[ktf]

These are the ones which should be safe to have in the vanilla branch. There are more to come, but for the moment they will only end up in the CLANG_X branch.

[cmsbuild]

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_1_X.

Fix a bunch of clang reported issues.

It involves the following packages:

CondFormats/SiStripObjects
RecoEgamma/EgammaHFProducers
RecoEgamma/EgammaPhotonAlgos
RecoJets/JetProducers
RecoLocalCalo/Castor
RecoLocalCalo/EcalRecAlgos
RecoLocalCalo/HcalRecAlgos
RecoLocalMuon/CSCEfficiency
RecoLocalTracker/SiPixelRecHits
RecoLocalTracker/SiStripRecHitConverter
RecoMuon/L3MuonProducer
RecoMuon/MuonSeedGenerator
RecoTracker/FinalTrackSelectors
RecoVertex/KinematicFit
RecoVertex/TertiaryTracksVertexFinder
RecoVertex/VertexTools
TrackingTools/TransientTrackingRecHit

@apfeiffer1, @diguida, @cmsbuild, @anton-a, @thspeer, @rcastello, @slava77, @ggovi, @Degano, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @TaiSakuma, @yslai, @GiacomoSguazzoni, @rovere, @lgray, @nhanvtran, @gpetruc, @cerati, @argiro, @bachtis, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
I found an error when building:

>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/RecoLocalTracker/SiStripRecHitConverter/src/CrosstalkInversion.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-05-08-0200/src/RecoLocalTracker/SiStripRecHitConverter/src/SiStripRecHitConverterAlgorithm.cc 
tmp/slc6_amd64_gcc481/src/CondFormats/SiStripObjects/src/CondFormatsSiStripObjects/a/xr.o: In function `(anonymous namespace)::method_4203(void*, void*, std::vector > const&, void*)':
xr.cc:(.text+0x4314): undefined reference to`std::string SiStripConfObject::getstd::string(std::string const&) const'
xr.cc:(.text+0x4326): undefined reference to `std::string SiStripConfObject::getstd::string(std::string const&) const'
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc481/src/CondFormats/SiStripObjects/src/CondFormatsSiStripObjects/libCondFormatsSiStripObjects.so] Error 1
gmake: **\* Waiting for unfinished jobs....
gmake: **\* [There are compilation/build errors. Please see the detail log above.] Error 2


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3772/1406/summary.html

[apfeiffer1]

+1
AlCaDB related changes are trivial.

[cmsbuild]

Pull request #3772 was updated. @apfeiffer1, @diguida, @cmsbuild, @anton-a, @thspeer, @rcastello, @slava77, @ggovi, @Degano, @nclopezo can you please check and sign again.

[cmsbuild]

-1
I found an error when building:

QGTagger.cc:(.text+0xfca): undefined reference to `std::type_info const& edm::typelookup::classTypeInfo()'
tmp/slc6_amd64_gcc481/src/RecoJets/JetProducers/plugins/RecoJetsJetProducers_plugins/QGTagger.o: In function`edm::eventsetup::NoRecordException::NoRecordException()':
QGTagger.cc:(.text._ZN3edm10eventsetup17NoRecordExceptionI15QGLikelihoodRcdEC2Ev[_ZN3edm10eventsetup17NoRecordExceptionI15QGLikelihoodRcdEC5Ev]+0x24): undefined reference to `char const* edm::typelookup::className()'
tmp/slc6_amd64_gcc481/src/RecoJets/JetProducers/plugins/RecoJetsJetProducers_plugins/QGTagger.o: In function`edm::eventsetup::NoRecordException::NoRecordException()':
QGTagger.cc:(.text._ZN3edm10eventsetup17NoRecordExceptionI26QGLikelihoodSystematicsRcdEC2Ev[_ZN3edm10eventsetup17NoRecordExceptionI26QGLikelihoodSystematicsRcdEC5Ev]+0x24): undefined reference to `char const\* edm::typelookup::className()'
collect2: error: ld returned 1 exit status
gmake: **\* [tmp/slc6_amd64_gcc481/src/RecoJets/JetProducers/plugins/RecoJetsJetProducers_plugins/libRecoJetsJetProducers_plugins.so] Error 1
gmake: **\* Waiting for unfinished jobs....
Copying tmp/slc6_amd64_gcc481/src/RecoJets/JetProducers/test/test-large-voronoi-area/test-large-voronoi-area to productstore area:
--- Registered EDM Plugin: EcalBasicUncalibRecHitFilter
--- Registered EDM Plugin: testEcalSampleMaskRecordESProducer


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3772/1421/summary.html

[ktf]

Something entered IB after my changes. Will look into it.

[slava77]

+1

for #3772 20bf6b4

tested in CMSSW_7_1_X_2014-05-12-0200 (test area sign369decB)
no changes

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (but tests are reportedly failing). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3772/1493/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3772/1493/summary.html