Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New MVA taggers backport from 71X to 70X #3774

Conversation

pvmulder
Copy link
Contributor

@pvmulder pvmulder commented May 9, 2014

Contains backport of the following 71X merged pull requests:
#2622
#3384
#3664
#3733

But also the unmerged 70X pull request to avoid clashes with backported code:
#3394

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_7_0_X.

New MVA taggers backport from 71X to 70X

It involves the following packages:

DataFormats/BTauReco
PhysicsTools/MVAComputer
PhysicsTools/PatAlgos
RecoBTag/SecondaryVertex
RecoVertex/AdaptiveVertexFinder

@nclopezo, @monttj, @cmsbuild, @anton-a, @thspeer, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@TaiSakuma, @GiacomoSguazzoni, @rovere, @nhanvtran, @ferencek, @cerati this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ferencek
Copy link
Contributor

ferencek commented May 9, 2014

@pvmulder #3394 is fully signed and should be merged very soon. It is therefore better to take it out of this PR (the first 8 commits are already included in #3394 but with different commit IDs and I don't really know how Git handles such cases). So if #3394 is not needed, I would take it out (we can always backport #3733 as a separate PR).

@vadler
Copy link

vadler commented May 9, 2014

#3394 has just been merged. You can rebase onto the coming IB.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

Pull request #3774 was updated. @vadler, @slava77, @StoyanStoynev, @monttj can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

@monttj
Copy link
Contributor

monttj commented Jun 14, 2014

+1
no difference in AT, already signed by Volker

@slava77
Copy link
Contributor

slava77 commented Jun 14, 2014

+1

for #3774 7172aef
tested in CMSSW_7_0_X_2014-06-13-1400 (test area sign706b)
no changes as expected from the code changes.

@cmsbuild @nclopezo this is to stay in 70X (no forward porting, we are dealing with a case with a feature implemented differently in the old release).

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 18, 2014
…_71X_to_70X

New MVA taggers backport from 71X to 70X
@davidlange6 davidlange6 merged commit bf95dbd into cms-sw:CMSSW_7_0_X Jun 18, 2014
@ferencek ferencek deleted the newMVAtaggers_backport_from_71X_to_70X branch June 18, 2014 17:02
ktf added a commit to ktf/cmssw that referenced this pull request Jun 19, 2014
This was referenced Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants