-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some deprecation warnings from DQMServices/Components
#37747
Conversation
ah, I see now that the conflicts are coming from #37706. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37747/29616
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
-1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0a8e9/24355/summary.html This pull request cannot be automatically merged, could you please rebase it? |
7443439
to
c599efa
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37747/29710
|
Pull request #37747 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
please test |
c599efa
to
1caa54d
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37747/29719
|
Pull request #37747 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0a8e9/24454/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
@mmusich Please have a look at some Static Checks warnings: |
@qliphy none of these have been introduced by me, see please the SA output of CMSSW_12_4_X_2022-05-05-2300: as such they should be treated by the DQM core team. |
+1 |
PR description:
Title says it all, remove some deprecation warnings from
DQMServices/Components
.In response to #37665 (comment)
Technical, part of the migrations in #36404.
Profited to clean-up headers and merging plugin header with implementations.
PR validation:
cmssw
compilesif this PR is a backport please specify the original PR and why you need to backport that PR:
N/A