Add support of TH1I and TH2I in DQM

[mmusich]

PR description:

Title say it all, possibly needed by #37619

PR validation:

Tested together with #37619 using runTheMatrix.py --what gpu -l 11634.503 on lxplus-gpu successfully.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37665/29468

• This PR adds an extra 52KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37665/29468/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37665/29468/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37665/29469

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQMServices/Core (dqm)
• DataFormats/Histograms (dqm, core)

@smuzaffar, @Dr15Jones, @makortel, @emanueleusai, @ahmad3213, @cmsbuild, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@barvic, @rovere this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37665/29472

• This PR adds an extra 64KB to repository

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3769ca/24342/summary.html
COMMIT: 9b600e7
CMSSW: CMSSW_12_4_X_2022-04-29-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37665/24342/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 1 inherits from legacy modules warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3769ca/24342/llvm-analysis/legacy-mod-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3695434
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3695404
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+core

Although the DQMStoreStats needs to be migrated from legacy module type, but that is probably beyond this PR.

[mmusich]

Although the DQMStoreStats needs to be migrated from legacy module type, but that is probably beyond this PR.

some of the deprecation warnings (that indeed are beyond the scope of this PR) are followed up at #37747, though it will require more work.

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

While looking for possible broken symmetries in the code, I notice that TH2I is not added to the MonitorElement::Fill method for weighted 2D histos:

cmssw/DQMServices/Core/src/MonitorElement.cc

Line 319 in 9b600e7

void MonitorElement::Fill(double x, double y, double zw) {

Was it done on purpose?

[mmusich]

Was it done on purpose?

No, but there is no use case at the moment, I can add it here, but not earlier than next Wednesday

[perrotta]

Was it done on purpose?

No, but there is no use case at the moment, I can add it here, but not earlier than next Wednesday

Well, if there is no use case for it, we can merge this PR as it is.

On the other hand, to cover in advance all possible future use cases one should add

• TH1I to the MonitorElement::doFill(int64_t ) method;
• TH2I to the MonitorElement::Fill(double , double , double ) method.

It can be left the @cms-sw/dqm-l2 to decide whether to implement it in a possible future PR or not. Thanks to this PR, those two possible additions can be rather straightforwardly implemented once this is merged

[perrotta]

+1

[mmusich]

@perrotta @cms-sw/dqm-l2

On the other hand, to cover in advance all possible future use cases one should add

addressed at #37795