-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove some more deprecated API warnings #37818
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37818/29735
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @slava77, @jpata, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a4372/24473/summary.html Comparison SummarySummary:
|
+1 |
+reconstruction
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
Handle<SimTrackContainer> simTrks; | ||
ev.getByLabel("g4SimHits", simTrks); | ||
// std::cout << "simtrks " << simTrks->size() << std::endl; | ||
// std::edm::LogPrint("PixelTrackTest") << "simtrks " << simTrks->size() << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// std::edm::LogPrint("PixelTrackTest") << "simtrks " << simTrks->size() << std::endl; | |
// edm::LogPrint("PixelTrackTest") << "simtrks " << simTrks->size(); |
(But ok, it is in a commented out line)
+1 |
PR description:
Removed some other deprecation warnings popping out in
CMSSW_12_4_CMSDEPRECATED_X_2022-05-04-2300
(I guess after #37592 was merged).Technical, part of the migrations in #36404.
Profited to clean-up headers and merging plugin header with implementations.
PR validation:
cmssw
compiles, no warnings seen after merging.if this PR is a backport please specify the original PR and why you need to backport that PR:
N/A