Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some more deprecated API warnings #37818

Merged
merged 1 commit into from
May 9, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented May 5, 2022

PR description:

Removed some other deprecation warnings popping out in CMSSW_12_4_CMSDEPRECATED_X_2022-05-04-2300 (I guess after #37592 was merged).
Technical, part of the migrations in #36404.
Profited to clean-up headers and merging plugin header with implementations.

PR validation:

cmssw compiles, no warnings seen after merging.

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37818/29735

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • DQMOffline/CalibTracker (dqm)
  • EventFilter/SiStripRawToDigi (reconstruction)
  • RecoPixelVertexing/PixelTrackFitting (reconstruction)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @clacaputo, @slava77, @jpata, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @felicepantaleo, @pieterdavid, @robervalwalsh, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @mtosi, @mmusich, @threus, @dgulhan, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@jpata
Copy link
Contributor

jpata commented May 5, 2022

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 5, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5a4372/24473/summary.html
COMMIT: 08dda3e
CMSSW: CMSSW_12_4_X_2022-05-05-1100/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/37818/24473/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3700704
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3700680
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@jpata
Copy link
Contributor

jpata commented May 9, 2022

+reconstruction

  • technical

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

Handle<SimTrackContainer> simTrks;
ev.getByLabel("g4SimHits", simTrks);
// std::cout << "simtrks " << simTrks->size() << std::endl;
// std::edm::LogPrint("PixelTrackTest") << "simtrks " << simTrks->size() << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// std::edm::LogPrint("PixelTrackTest") << "simtrks " << simTrks->size() << std::endl;
// edm::LogPrint("PixelTrackTest") << "simtrks " << simTrks->size();

(But ok, it is in a commented out line)

@perrotta
Copy link
Contributor

perrotta commented May 9, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants