Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_3_X + remove customizeHLTforPatatrack.py [12_4_X] #37862

Merged
merged 1 commit into from May 9, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented May 9, 2022

PR description:

Development of HLT menus for CMSSW_12_3_X.

This is the PR for the master branch, which will then be backported to 12_3_X (which is currently the release used for HLT-menu development for Run 3).

Includes the integration of the following JIRA tickets.

  • CMSHLT-2298: [TSG] Update of GPU-related modules in the HLT combined table (use only EDAliases inside SwitchProducers)

This PR also removes the Patatrack customisation functions for HLT from the master branch of CMSSW. After the integration of CMSHLT-2288, those customisations are not needed anymore (cc: @fwyzard).

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-37862/29812

  • This PR adds an extra 812KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)
  • RecoTauTag/HLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mbluj, @silviodonato, @azotz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented May 9, 2022

urgent

To signal that this PR targets integration in time for 12_4_0_pre4.

@cmsbuild cmsbuild added the urgent label May 9, 2022
@missirol
Copy link
Contributor Author

missirol commented May 9, 2022

enable gpu

To check that the GPU workflows are unaffected by the removal of the Patatrack customisations.

@missirol
Copy link
Contributor Author

missirol commented May 9, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c765ff/24539/summary.html
COMMIT: bfaa136
CMSSW: CMSSW_12_4_X_2022-05-09-1100/slc7_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37862/24539/install.sh to create a dev area with all the needed externals and cmssw changes.

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 24 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19874
  • DQMHistoTests: Total failures: 973
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 18901
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: no differences found

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3696627
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3696585
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 206 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented May 9, 2022

+hlt

  • no significant differences in PR-test outputs, as expected (aside for wf 11634.506, which is known to be not fully reproducible)

@cmsbuild
Copy link
Contributor

cmsbuild commented May 9, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented May 9, 2022

+1

@cmsbuild cmsbuild merged commit 7b896c2 into cms-sw:master May 9, 2022
@missirol missirol deleted the HLTdevelopment123X_for124X branch May 9, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants