[12_3_X] Fill LumiRange for BeamSpotOnline objects

[francescobrivio]

PR description:

Backport of #37875
As noticed in #37858 (comment) the lumiRange member of the BeamSpotOnline objects was never filled in DQM/BeamMonitor and it defaulted to an empty string.
This PR correctly fills the value with the string [firstLS] - [lastLS] used in the BeamSpot fit.

PR validation:

Code compiles plus @cms-sw/dqm-l2 experts (@pmandrik @ahmad3213) should test this in P5.

Backport:

Backport of #37875

FYI @dzuolo @gennai

[cmsbuild]

A new Pull Request was created by @francescobrivio for CMSSW_12_3_X.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Fill LumiRange for BeamSpotOnline objects #37875

[francescobrivio]

backport of #37875

[francescobrivio]

type bug-fix

[francescobrivio]

test parameters:

• addpkg = DQM/Integration

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b9cab2/24557/summary.html
COMMIT: 8c8fdf9
CMSSW: CMSSW_12_3_X_2022-05-09-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/37877/24557/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3696087
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3696057
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 48 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 204 log files, 45 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

[francescobrivio]

+1

Thanks @emanueleusai!
Was this tested in the P5 playback system already?

[pmandrik]

Hi, included into playback release starting from run 504585, all clients run fine.

[francescobrivio]

+db

• given comment in [12_3_X] Fill LumiRange for BeamSpotOnline objects #37877 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1