Corrections for HGCal v17 geometry

[Pruthvi-ch]

PR description:

Correction for cassettes and partial wafers for v17 version of HGCal geometry.

PR validation:

Tested using overlap checking tool and fireworks for V17 versions of HGCal geometry

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38040/30120

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Pruthvi-ch for master.

It involves the following packages:

• Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@trtomei, @bsunanda, @beaucero, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4b43fc/24907/summary.html
COMMIT: 3ece8a2
CMSSW: CMSSW_12_5_X_2022-05-23-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38040/24907/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3650985
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3650955
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[cvuosalo]

+1

[bsunanda]

@srimanob Could you please approve this PR. Needed for V17 version of HGCal Geometry

[srimanob]

+Upgrade

The V17 HGCal (should correspond to C18 in Geometry conf) is new and not yet in detector description. Fixing/modifying it should not effect existing geometry. Maybe @bsunanda and @Pruthvi-ch can confirm that changes in this PR will not effect others.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[Pruthvi-ch]

@srimanob This does not affect the existing geometry. These functions are only used in the v17 geometry.

[qliphy]

+1