-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop tracker geometry T29 (last with bricked pixels) #38061
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38061/30142
|
A new Pull Request was created by @emiglior (Ernesto Migliore) for master. It involves the following packages:
@perrotta, @malbouis, @civanch, @yuanchao, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @kskovpen, @bbilin, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
test parameters:
|
@cmsbuild , please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41a5e9/24947/summary.html Comparison SummarySummary:
|
+1 |
+alca |
given that the bricked pixels are removed for good from the supported geometries, I am wondering if the corresponding local reco code could be removed as well, thus addressing #35519 as well. |
could you please proceed with the sign-off of the PR so that we can address this issue? |
+Upgrade This PR drops T29 and related geometry. No change is expected in other geometry. |
@cms-sw/pdmv-l2 any objections? |
+pdmv |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
This PR concerns Upgrade.
This PR removes the phase-2 Tracker geometry T29 (last geometry left featuring bricked pixels) definitively discarded after the choice of the Inner Tracker layout (see also PR #37874).
The PR removes both the geometry files and the corresponding workflows.
The file
Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
is also changed in order to preserve the workflow numbers.
No changes are expected in the output for the geometries/workflows which are kept.
PR validation:
The PR was validated with runTheMatrix checking that
if this PR is a backport please specify the original PR and why you need to backport that PR:
This PR is not a backport
@adewit @connorpa @franzglessgen @mmusich @tsusa @tvami FYI