Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop tracker geometry T29 (last with bricked pixels) #38061

Merged
merged 1 commit into from
May 30, 2022

Conversation

emiglior
Copy link
Contributor

PR description:

This PR concerns Upgrade.

This PR removes the phase-2 Tracker geometry T29 (last geometry left featuring bricked pixels) definitively discarded after the choice of the Inner Tracker layout (see also PR #37874).

The PR removes both the geometry files and the corresponding workflows.

The file
Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py
is also changed in order to preserve the workflow numbers.

No changes are expected in the output for the geometries/workflows which are kept.

PR validation:

The PR was validated with runTheMatrix checking that

  • w/f numbers for geometries from 2026D88 to 2026D91 did not change
  • running explicitly the w/f 39400.0 (2026D88) 40600.0 (2026D91)

if this PR is a backport please specify the original PR and why you need to backport that PR:

This PR is not a backport

@adewit @connorpa @franzglessgen @mmusich @tsusa @tvami FYI

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38061/30142

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @emiglior (Ernesto Migliore) for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/Eras (operations)
  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)
  • Geometry/TrackerCommonData (geometry)

@perrotta, @malbouis, @civanch, @yuanchao, @jordan-martins, @makortel, @cvuosalo, @ianna, @mdhildreth, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @Dr15Jones, @kskovpen, @bbilin, @qliphy, @francescobrivio, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@felicepantaleo, @kpedro88, @ghugo83, @Martin-Grunewald, @bsunanda, @trtomei, @mmusich, @slomeo, @venturia, @vargasa, @makortel, @JanFSchulte, @dgulhan, @missirol, @beaucero, @GiacomoSguazzoni, @rovere, @VinInn, @tocheng, @ebrondol, @mtosi, @fabiocos, @lecriste this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented May 24, 2022

test parameters:

  • workflows = 39400.0,40600.0

@tvami
Copy link
Contributor

tvami commented May 24, 2022

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-41a5e9/24947/summary.html
COMMIT: e8f0a4a
CMSSW: CMSSW_12_5_X_2022-05-24-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38061/24947/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3650985
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3650955
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@cvuosalo
Copy link
Contributor

+1

@tvami
Copy link
Contributor

tvami commented May 24, 2022

+alca

@mmusich
Copy link
Contributor

mmusich commented May 24, 2022

given that the bricked pixels are removed for good from the supported geometries, I am wondering if the corresponding local reco code could be removed as well, thus addressing #35519 as well.

@emiglior
Copy link
Contributor Author

could you please proceed with the sign-off of the PR so that we can address this issue?

#35519

@srimanob
Copy link
Contributor

srimanob commented May 26, 2022

+Upgrade

This PR drops T29 and related geometry. No change is expected in other geometry.

@mmusich
Copy link
Contributor

mmusich commented May 30, 2022

@cms-sw/pdmv-l2 any objections?
Thank you.

@kskovpen
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants