Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove model files of depreciated tauIds. #9

Merged
merged 2 commits into from Jun 1, 2022

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented May 24, 2022

As title says, this PR removes model files of depreciated tauIds: DPFIsolation v0 and v1, and DeepTauId v1.
This PR complements cms-sw/cmssw#38063.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for branch master.

@smuzaffar, @aandvalenzuela, @iarspider, @clacaputo, @cmsbuild, @slava77, @jpata can you please review it and eventually sign? Thanks.
@mbluj, @azotz this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.
cms-bot commands are listed here

@perrotta
Copy link

please test with cms-sw/cmssw#38063

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0fcca/25084/summary.html
COMMIT: e7ad063
CMSSW: CMSSW_12_5_X_2022-05-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-data/RecoTauTag-TrainingFiles/9/25084/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0fcca/25084/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0fcca/25084/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 373 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3648315
  • DQMHistoTests: Total failures: 1121
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3647172
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link

Differences in reco outputs are due to the additional merge commits added while running this PR.
The important thing is that nothing crashes when running this together with cms-sw/cmssw#38063

Please @cms-sw/reconstruction-l2 have a look and sign, if you have nothing against this removal of now unused data files

@smuzaffar
Copy link
Contributor

+externals

@perrotta
Copy link

perrotta commented Jun 1, 2022

@jpata @clacaputo : it is certainly not urgent, but if you agree with removing these data files after the removal of the tauIds which were using them (by the already merged cms-sw/cmssw#38164), please let us know by signing this PR

@clacaputo
Copy link

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 1, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link

perrotta commented Jun 1, 2022

+1

@perrotta
Copy link

perrotta commented Jun 1, 2022

ping bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants