Let PFClusterEMEnergyCorrector run without SRB inputs

[fwyzard]

PR description:

Let the PFClusterEMEnergyCorrector run also in the absence of the ECAL selective bit readout collections.

If these collections are not present (or empty) the PFClusterEMEnergyCorrector will assume all hits to have been read with "full readout", without any zero suppression.

PR validation:

None.

[fwyzard]

please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38081/30174

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• RecoParticleFlow/PFClusterProducer (reconstruction)

@jpata, @clacaputo, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @felicepantaleo, @rovere, @lgray, @lecriste, @hatakeyamak, @ebrondol, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

This PR is necessary to resolve the GPU-CPU difference we observed in PF ECAL (details in https://its.cern.ch/jira/browse/CMSHLT-2315).
cc @cms-sw/hlt-l2

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6cc7/24996/summary.html
COMMIT: 894088f
CMSSW: CMSSW_12_5_X_2022-05-24-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38081/24996/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 1313.01313.0_QCD_Pt_3000_3500_13+QCD_Pt_3000_3500_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_QCD_Pt_3000_3500_13+QCD_Pt_3000_3500_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
• 1314.01314.0_WpM_13+WpM_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_WpM_13+WpM_13INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log
• 1315.01315.0_SingleElectronPt10_UP15+SingleElectronPt10_UP15INPUT+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleElectronPt10_UP15+SingleElectronPt10_UP15INPUT+DIGIUP15+RECOUP15+HARVESTUP15.log

Expand to see more relval errors ...

• 1316.0
• 1317.0
• 1319.0

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3650985
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3650955
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[jpata]

assign hlt

[jpata]

assign hlt

[cmsbuild]

New categories assigned: hlt

@missirol,@Martin-Grunewald you have been requested to review this Pull request/Issue and eventually sign? Thanks

[jpata]

+reconstruction

• bugfix for HLT (no reco effect)

[jpata]

+reconstruction

• bugfix for HLT (no reco effect)

[fwyzard]

please test

[fwyzard]

let's see if the relvas input tets work...

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bf6cc7/25078/summary.html
COMMIT: 894088f
CMSSW: CMSSW_12_5_X_2022-05-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38081/25078/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3648315
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3648285
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• effectively downgrades an exception to a LogInfo
• needed as part of CMSHLT-2315, to reduce CPU-GPU discrepancies related to ECAL
• no differences in PR-tests outputs expected, nor observed

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1