[12_4_X] Compute muon index bits using idx from dataformat

[dinyar]

PR description:

We currently compute the muon index within the link from the position in the vector, however this is packed densely and during cosmics the EMTF always sends muon stubs in third position (even if the second position is free), causing a mismatch in index bits.

Therefore we now assign the muon index on the link in the uGMT unpacker and use that index if it is set. The behaviour when the muIdx field is not explicitly set should be identical to the current one.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38035 as requested in #38035 (comment).

Would like this in for the DQM at P5.

[cmsbuild]

A new Pull Request was created by @dinyar (Dinyar Rabady) for CMSSW_12_4_X.

It involves the following packages:

• DataFormats/L1TMuon (l1)
• EventFilter/L1TRawToDigi (l1)
• L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

• Backported from Compute muon index bits using idx from dataformat #38035

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-52c8e3/25065/summary.html
COMMIT: 6c39638
CMSSW: CMSSW_12_4_X_2022-05-29-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38116/25065/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3672457
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3672433
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

backport of #38035

[perrotta]

+1

• Merged in master since CMSSW_12_5_X_2022-05-30-2300