Compute muon index bits using idx from dataformat

[dinyar]

PR description:

We currently compute the muon index within the link from the position in the vector, however this is packed densely and during cosmics the EMTF always sends muon stubs in third position (even if the second position is free), causing a mismatch in index bits.

Therefore we now assign the muon index on the link in the uGMT unpacker and use that index if it is set. The behaviour when the muIdx field is not explicitly set should be identical to the current one.

PR validation:

Running the usual standard tests locally. (WIP until they succeed.)

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38035/30113

• This PR adds an extra 32KB to repository

[cmsbuild]

A new Pull Request was created by @dinyar (Dinyar Rabady) for master.

It involves the following packages:

• DataFormats/L1TMuon (l1)
• EventFilter/L1TRawToDigi (l1)
• L1Trigger/L1TMuon (l1)

@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @rovere, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38035/30217

• This PR adds an extra 28KB to repository

[cmsbuild]

Pull request #38035 was updated. @epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please check and sign again.

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a3c7c6/25054/summary.html
COMMIT: 6c39638
CMSSW: CMSSW_12_5_X_2022-05-27-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38035/25054/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3648315
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3648285
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[dinyar]

Ok, for me this looks like no changes were seen in the tests which is expected. The only place we should see differences is during cosmics data taking in the data-emulator comparisons.

Once this is merged I'd like to have this in the online DQM if that's possible. @jfernan2, can you let me know if that would be fine?

Cheers,
Dinyar

[jfernan2]

Hi, yes, it is possible, but we'd better coordinate with @pmandrik @emanueleusai, @ahmad3213 @micsucmed @rvenditti who are the DQM responsibles.
You will need to backport in a PR these changes anyway to 12_3_X which is the version used right now in Online.
Besides, to keep the code in sync, another PR backporting to 12_4_X would be fine, to not lose the changes when Online moves to that release in a near future. Thanks

[dinyar]

Hi, yes, it is possible, but we'd better coordinate with @pmandrik @emanueleusai, @ahmad3213 @micsucmed @rvenditti who are the DQM responsibles. You will need to backport in a PR these changes anyway to 12_3_X which is the version used right now in Online. Besides, to keep the code in sync, another PR backporting to 12_4_X would be fine, to not lose the changes when Online moves to that release in a near future. Thanks

Ok, thanks for the information. Backports made at #38116 and #38117.

[epalencia]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1