Remove depreciated DNN-based tau-Ids [12_4_X] #38164
Conversation
|
A new Pull Request was created by @mbluj for CMSSW_12_4_X. It involves the following packages:
@jpata, @cmsbuild, @clacaputo, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Sorry if I missed it, but where was the backport requested and what's the motivation? |
The main motivation of the backport is to remove unused code and synchronize cms-data used by 12_4_X and master (12_5_X) which a) removes depreciated model files (size reduction of cms-distr) and b) enables coherent update of model files of deepTau v2p5 (on top of removal of the depreciated ones). However, if you think it that b) (most important for MC production with 124X) is not worth of merging this PR it can be closed. Then we will prepare different update of cms-data with updated deepTau v2p5 model files. I hope this comment is not confusing... |
|
Hi @mbluj , so the reason for the bp is intended to remove code not used in If so, I don't see any problem with doing so, maybe @cms-sw/orp-l2 has a different opinion |
It is correct. |
Fine with me under the context |
|
@cmsbuild please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9279aa/25255/summary.html Comparison SummarySummary:
|
|
enable profiling |
|
@cmsbuild please test with cms-data/RecoTauTag-TrainingFiles#10 |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9279aa/25307/summary.html Comparison SummarySummary:
|
Yes, I confirm, three tauIDs can be changed by the updated model files added in cms-data/RecoTauTag-TrainingFiles#10, while the rest should be unchanged. Test repeated without updated model is expected to show no changes. |
|
It seems the profiling job is stuck, but the comparison job ended successfully and plots can be checked here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_12_4_X_2022-06-07-2300+9279aa/50849/validateJR.html As expected, the PR is not introducing any reco changes |
|
@cmsbuild please abort |
|
test parameters:
|
|
@cmsbuild please test |
|
As stated in #38164 (comment) , there are NO reco differences after test this PR without cms-data/RecoTauTag-TrainingFiles#10, but it seems that a profiling job pending is not letting the checks to finish. I'm ready to sign the PR as soon as the test finish |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9279aa/25394/summary.html Comparison SummarySummary:
|
@clacaputo , there is a known issue with bot that it does not reset status for tests which were initially run (e.g. in this case |
|
+reconstruction
|
cmsbuild
added
fully-signed
reconstruction-approved
and removed
reconstruction-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
This PR is to remove depreciated DNN-based tau-Ids: DPFIsolation (a dedicated module) and DeepTauID v1 (a v1-related part of the deepTauId module). These tau-Ids was superseded by deepTauID v2 and are not present in official workflows.
In addition two outdated and unused modules are also removed.
No changes are expected.
This PR is accompanied by another PR to cms-data removing model files of removed DNN-based tau-Ids (cms-data/RecoTauTag-TrainingFiles#9) or its updated version cms-data/RecoTauTag-TrainingFiles#10.
This is backport of #38063.
PR validation:
Limited matrix tests successful in original PR (#38063). Not repeated here as differences between master and 12_4_X are minimal (can be done on request).
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #38063.
Removal of outdated code and (more importantly) reduction of size of cms-distr thanks to removal of old model files when cms-data/RecoTauTag-TrainingFiles#9 merged. Finally it enables adding to cms-distr of 12_4_X new model files of newest deepTauID v2p5 requested in cms-data/RecoTauTag-TrainingFiles#10.