Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.4.X] Introduce TkAlJetHT #38261

Merged
merged 3 commits into from Jun 8, 2022

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Jun 6, 2022

backport of #38254

PR description:

In PR #27307 the TkAlMinBias ALCARECO flavour was added to the JetHT dataset in the autoAlCa file, in order to have it produced for the Run-2 Ultra-Legacy reprocessing.
Operational experience with it has indicated that the resulting PDs are too large to be able tocomfortably distribute them at the target T2s, so that workflow is superseded by adding a new producer TkAlJetHT tailored to be used on the JetHT sample, which contains a prescale of 10 (1 event of ten input events will be processed). This should alleviate the output size and the burden on disk and operation teams.
This is proposed in this PR. As a new eventSetupPathsKey (= TkAlJetHTHLT) is introduced here a new set of AlCaRecoTriggerBitsRcd tags:

  • AlCaRecoHLTpaths_2017_offline_v6 which is a superset of the production tag AlCaRecoHLTpaths_2017_offline_v4, but will all IOVs substituted by new payloads adding the TkAlJetHT key (used in auto:run2_data*)
  • AlCaRecoHLTpaths_2021_offline_v2 which is a superset of the production tag AlCaRecoHLTpaths_2021_offline_v1, but will all IOVs substituted by new payloads adding the TkAlJetHT key (used in auto:run3_data*)

PR validation:

Run successfully the Tier-0 testing workflow:

runTheMatrix.py -l 1000.0

if this PR is a backport please specify the original PR and why you need to backport that PR:

verbatim backport of #38254

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X.

It involves the following packages:

  • Alignment/CommonAlignmentProducer (alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/StandardSequences (operations)
  • DQMOffline/Alignment (dqm)

@perrotta, @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @francescobrivio, @davidlange6 can you please review it and eventually sign? Thanks.
@pakhotin, @fabiocos, @adewit, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @ebrondol, @tocheng, @lecriste, @tlampen, @mmusich, @mtosi, @dgulhan, @slomeo, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Jun 6, 2022

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7a77/25313/summary.html
COMMIT: 2e5cd7c
CMSSW: CMSSW_12_4_X_2022-06-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38261/25313/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 22 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3671502
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3671471
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1810.506 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 1810.459 KiB AlCaReco/TkAlJetHT
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@tvami
Copy link
Contributor

tvami commented Jun 7, 2022

@cms-sw/orp-l2 this is essentially fully signed

@mmusich
Copy link
Contributor Author

mmusich commented Jun 8, 2022

@cms-sw/orp-l2 as far as I can tell from the cmssw dashboard, the master PR of this backport (#38254) hasn't caused any troubles, could we consider this for inclusion?

@qliphy
Copy link
Contributor

qliphy commented Jun 8, 2022

@mmusich This one has conflict to be resolved, due to the merge of the big PR: #38265
Thanks!

@mmusich
Copy link
Contributor Author

mmusich commented Jun 8, 2022

@qliphy : #38265 was merged 4 minutes ago.
Did you merge that one explicitly before to create the conflict??

@mmusich
Copy link
Contributor Author

mmusich commented Jun 8, 2022

@tvami please clarify if the GTs proposed here are still OK after the merge of #38265

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

Pull request #38261 was updated. @perrotta, @malbouis, @yuanchao, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @cmsbuild, @jfernan2, @qliphy, @rvenditti, @micsucmed, @fabiocos, @francescobrivio, @davidlange6 can you please check and sign again.

@mmusich
Copy link
Contributor Author

mmusich commented Jun 8, 2022

@cmsbuild, please test

@tvami
Copy link
Contributor

tvami commented Jun 8, 2022

+alca

  • signing in advance, it's just a rebase

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7a77/25364/summary.html
COMMIT: 7f554fc
CMSSW: CMSSW_12_4_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38261/25364/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7a77/25364/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fc7a77/25364/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3671502
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 2
  • DQMHistoTests: Total successes: 3671465
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1810.5020000000002 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 1810.459 KiB AlCaReco/TkAlJetHT
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 8, 2022

@cms-sw/orp-l2 it would be nice to have this in for 2300 IB too... We already have another update on the GT for 12_4_X

@emanueleusai
Copy link
Member

+1

@perrotta
Copy link
Contributor

perrotta commented Jun 8, 2022

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit a5ef8e5 into cms-sw:CMSSW_12_4_X Jun 8, 2022
@mmusich mmusich deleted the addTkAlJetHT_12_4_X branch June 8, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants