Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Include EGM and L1T tags in mcRun3 and data GTs #38293

Merged
merged 1 commit into from
Jun 10, 2022

Conversation

tvami
Copy link
Contributor

@tvami tvami commented Jun 8, 2022

PR description:

See PR38283

The GT diffs are listed below:
run3_hlt
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_HLT_frozen_v6/123X_dataRun3_HLT_frozen_v5

run3_hlt_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_dataRun3_HLT_relval_v1/123X_dataRun3_HLT_relval_v9

run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_dataRun3_v2/124X_dataRun3_v1

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_dataRun3_relval_v2/124X_dataRun3_relval_v1

phase1_2022_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022_design_v4/124X_mcRun3_2022_design_v3

phase1_2022_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022_realistic_v4/124X_mcRun3_2022_realistic_v3

phase1_2022_cosmics
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022cosmics_realistic_deco_v5/124X_mcRun3_2022cosmics_realistic_deco_v4

phase1_2022_cosmics_design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022cosmics_design_deco_v4/124X_mcRun3_2022cosmics_design_deco_v3

phase1_2022_realistic_hi
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2022_realistic_HI_v4/124X_mcRun3_2022_realistic_HI_v3

phase1_2023_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2023_realistic_v4/124X_mcRun3_2023_realistic_v3

phase1_2024_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun3_2024_realistic_v4/124X_mcRun3_2024_realistic_v3

phase2_realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//124X_mcRun4_realistic_v5/124X_mcRun4_realistic_v4

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38283

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2022

A new Pull Request was created by @tvami (Tamas Vami) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor Author

tvami commented Jun 8, 2022

test parameters:

  • workflows = 136.897, 12034.0, 7.23, 12834.0

@tvami
Copy link
Contributor Author

tvami commented Jun 8, 2022

type egamma

@tvami
Copy link
Contributor Author

tvami commented Jun 8, 2022

@cmsbuild , please test

@tvami
Copy link
Contributor Author

tvami commented Jun 8, 2022

backport of #38283

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7c587/25377/summary.html
COMMIT: 90edd66
CMSSW: CMSSW_12_4_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38293/25377/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7c587/25377/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c7c587/25377/git-merge-result

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c7c587/12034.0_TTbar_14TeV+2021Design+TTbar_14TeV_TuneCP5_GenSim+Digi+RecoNano+HARVESTNano
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c7c587/136.897_RunCosmics2021CRUZET+RunCosmics2021CRUZET+RECOCOSDRUN3+ALCACOSDRUN3+HARVESTDCR3
  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-c7c587/7.23_Cosmics_UP21+Cosmics_UP21+DIGICOS_UP21+RECOCOS_UP21+ALCACOS_UP21+HARVESTCOS_UP21

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 54
  • DQMHistoTests: Total histograms compared: 4076426
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 4076401
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1810.506 KiB( 53 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 1810.459 KiB AlCaReco/TkAlJetHT
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Warnings
  • Checked 226 log files, 45 edm output root files, 54 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor

+alca

  • @tvami could you add to the PR description the GT diff links?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor Author

tvami commented Jun 9, 2022

could you add to the PR description the GT diff links?

Done, straight copy paste from the master PR

@qliphy
Copy link
Contributor

qliphy commented Jun 10, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants