Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 12_4_X (2/N) #38242

Merged
merged 1 commit into from Jun 10, 2022

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Jun 4, 2022

backport of #38241

PR description:

Development of HLT menus for CMSSW_12_4_X.

Includes the integration of the following JIRA tickets.

  • CMSHLT-2273: [BPH] Double-electron triggers for R(X)-type analyses (partly integrated)
  • CMSHLT-2281: [HIG] Update of DijetVBF+2Tau trigger
  • CMSHLT-2282: [EXO] PFMETNoMu trigger with HF cleaning + low-pT double-photon triggers (partly integrated)
  • CMSHLT-2284: [HIG] Backup and control triggers for 2Tau+Jet trigger
  • CMSHLT-2285: [HIG] Control triggers for VBF+2Tau trigger
  • CMSHLT-2289: [TAU] Update of VBF+2Tau triggers
  • CMSHLT-2291: [B2G] SingleJet and DiJet Triggers on AK8 jets with softdrop-mass cut
  • CMSHLT-2306: [TOP] Update of DeepJet WP for HT+6Jet+1BTag trigger
  • CMSHLT-2308: [BPH] Update of triggers for Tau->3Mu search (amended with respect to #38108)
  • CMSHLT-2314: [JME] Low-pT single-photon trigger for jet-energy corrections
  • CMSHLT-2316: [TSG] run Pixel DQM (CPU-vs-GPU) inside the HLT
  • CMSHLT-2321: [EXO] Backup and monitoring triggers for displaced-dimuon searches
  • CMSHLT-2324: [TSG] Naming: changed AlCaLumiPixelCounts to AlCaLumiPixelsCounts
  • CMSHLT-2325: [TRK,AlCa,TSG] Update of DQMOnlineBeamspot EventContent and FEDSelector for TCDS
  • CMSHLT-2330: [TAU,HIG] Naming: changed "DeepTauIso" label to "DeepTau"
  • CMSHLT-2333: [EGM,HIG] Naming: removed "NoPixelVeto" label from Diphoton Paths (partly integrated)

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR:

#38241

Development of HLT menus for 2022 pp data-taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2022

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Jun 4, 2022

enable gpu

To better test the update of the DQM path, which only runs on GPU.

@missirol
Copy link
Contributor Author

missirol commented Jun 4, 2022

please test

@missirol
Copy link
Contributor Author

missirol commented Jun 4, 2022

please abort

@missirol
Copy link
Contributor Author

missirol commented Jun 4, 2022

hold

See #38241 (comment).

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 4, 2022

Pull request has been put on hold by @missirol
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

Pull request #38242 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2022

Pull request #38242 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2022

Pull request #38242 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@tvami
Copy link
Contributor

tvami commented Jun 8, 2022

@cmsbuild , please test with #38293

@missirol
Copy link
Contributor Author

missirol commented Jun 8, 2022

unhold

@cmsbuild cmsbuild removed the hold label Jun 8, 2022
@missirol
Copy link
Contributor Author

missirol commented Jun 9, 2022

It seems that some of the tests are having trouble finishing.

@smuzaffar , what you would suggest to do in this case? Does one need to restart the tests from scratch?

@smuzaffar
Copy link
Contributor

smuzaffar commented Jun 9, 2022

The pending test requires a HTCondor based GPU node. 4 hours ago, cmsbot has requested the allocation of such node but sometimes it can take few hours to get this type of resource. I would suggest to wait few more hours

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-502456/25376/summary.html
COMMIT: 7a91d7a
CMSSW: CMSSW_12_4_X_2022-06-08-1100/el8_amd64_gcc10
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38242/25376/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-502456/25376/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-502456/25376/git-merge-result

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • Reco comparison had 3 failed jobs
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19864
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19856
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 20 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3668754
  • DQMHistoTests: Total failures: 285
  • DQMHistoTests: Total nulls: 99
  • DQMHistoTests: Total successes: 3668348
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 6120.827999999999 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 1810.459 KiB AlCaReco/TkAlJetHT
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Errors
  • DQMHistoSizes: changed ( 1000.0 ): 0.023 KiB MessageLogger/Warnings
  • DQMHistoSizes: changed ( 11634.0,... ): 438.834 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): 215.022 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): 111.191 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): -54.365 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11634.0,... ): 22.390 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -13.316 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 11634.0,... ): -6.582 KiB HLT/Higgs
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: found differences in 6 / 49 workflows

@missirol
Copy link
Contributor Author

missirol commented Jun 9, 2022

+hlt

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 10, 2022

+1

@cmsbuild cmsbuild merged commit ee16363 into cms-sw:CMSSW_12_4_X Jun 10, 2022
@missirol missirol deleted the HLTdevelopment124X branch June 10, 2022 17:28
@missirol missirol changed the title HLT menu development for 12_4_X HLT menu development for 12_4_X (2/N) Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants