miscellaneous improvements in CondFormats/PCLConfig

[mmusich]

PR description:

This PR is a follow-up to #38195, introducing miscellaneous improvements to the CondFormats/PCLConfig package.

• added integer and string parameter size enums for not yet used parameters and changed the logic to calculate the payload version
• fully templated also the AlignPCLThresholdsWriter writer class;
• improved the printAll() method of AlignPCLThresholdsHG in order to give a more synoptic view of the parameters;
• complemented unit tests in order to test both LG and HG classes;

PR validation:

run the dedicated unit tests: scram b runtests

if this PR is a backport please specify the original PR and why you need to backport that PR:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38286/30439

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondFormats/PCLConfig/interface/AlignPCLThresholdsHG.h modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/plugins/AlignPCLThresholdsReader.cc modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/plugins/AlignPCLThresholdsWriter.cc modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/test/AlignPCLThresholdsReader_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/test/AlignPCLThresholdsWriter_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondFormats/PCLConfig (db, alca)

@malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38286/30444

• This PR adds an extra 20KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondFormats/PCLConfig/interface/AlignPCLThresholdsHG.h modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/plugins/AlignPCLThresholdsReader.cc modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/plugins/AlignPCLThresholdsWriter.cc modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/src/AlignPCLThresholdsHG.cc modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/test/AlignPCLThresholdsReader_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429
  • File CondFormats/PCLConfig/test/AlignPCLThresholdsWriter_cfg.py modified in PR(s): Adding HZZ electron MVA ID #37429

[cmsbuild]

Pull request #38286 was updated. @malbouis, @yuanchao, @cmsbuild, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[mmusich]

please test

[tvami]

type trk

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c313f/25360/summary.html
COMMIT: a4f5d67
CMSSW: CMSSW_12_5_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38286/25360/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

• 138.4138.4_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3/step2_PromptCollisions+RunMinimumBias2021+ALCARECOPROMPTR3+HARVESTDPROMPTR3.log

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3652078
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3652048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mmusich]

-1

Not clear from the log what is the reason of failure. I am not expecting this to affect any workflow.

[mmusich]

@cmsbuild please test

• to see if it was a glitch

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4c313f/25370/summary.html
COMMIT: a4f5d67
CMSSW: CMSSW_12_5_X_2022-06-08-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38286/25370/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3652078
• DQMHistoTests: Total failures: 8
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3652048
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[tvami]

+1

• test pass, no unexpected diffs
• PR is according to the description

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1