[12_4_X] Fix ThroughputServiceClient.cc unsigned variables overflow

[pmandrik]

PR description:

TH1F FindFirstBinAbove() can return -1 [0] when hist is empty overflowing unsigned variables uint64_t first and uint64_t last. The next two loops for (unsigned int i = first; i <= last; ++i) became very long and hlt_clientPB DQM client is not able to exit in time when the run is ended. Affect Online DQM operation.

[0] https://root.cern.ch/doc/master/classTH1.html#a63960594f84aea92e5fa2d5129b49007

PR validation:

Tested at P5 DQM playback.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38282

[cmsbuild]

A new Pull Request was created by @pmandrik for CMSSW_12_4_X.

It involves the following packages:

• HLTrigger/Timer (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[Martin-Grunewald]

please test

[missirol]

type bugfix

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11d8e8/25428/summary.html
COMMIT: 2b621f9
CMSSW: CMSSW_12_4_X_2022-06-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38317/25428/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @tvami [12_4_X] Include EGM and L1T tags in mcRun3 and data GTs #38293
• @quark2 A backport of the fix on issue #38044 to 12_4_X #38278
• @cms-tsg-storm HLT menu development for 12_4_X (2/N) #38242
• @wpcarvalho Backport XML source file describing PPS pixel 2022 DAQ mapping to 12_4_X #38303

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11d8e8/25428/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-11d8e8/25428/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3669319
• DQMHistoTests: Total failures: 311
• DQMHistoTests: Total nulls: 98
• DQMHistoTests: Total successes: 3668888
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 82231.05600000001 KiB( 49 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 438.834 KiB HLT/JME
• DQMHistoSizes: changed ( 11634.0,... ): 215.022 KiB HLT/TAU
• DQMHistoSizes: changed ( 11634.0,... ): 111.191 KiB HLT/HLTEgammaValidation
• DQMHistoSizes: changed ( 11634.0,... ): -54.365 KiB HLT/HIG
• DQMHistoSizes: changed ( 11634.0,... ): 22.390 KiB HLT/EGM
• DQMHistoSizes: changed ( 11634.0,... ): -13.316 KiB HLT/Exotica
• DQMHistoSizes: changed ( 11634.0,... ): -6.582 KiB HLT/Higgs
• DQMHistoSizes: changed ( 11634.0,... ): 5.213 KiB HLT/Filters
• DQMHistoSizes: changed ( 35034.0,... ): 12986.789 KiB GEM/Digis
• Checked 208 log files, 45 edm output root files, 50 DQM output files
• TriggerResults: found differences in 6 / 49 workflows

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1