Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[123X] Include EGM regression in offline data GTs #38295

Closed

Conversation

malbouis
Copy link
Contributor

@malbouis malbouis commented Jun 9, 2022

PR description:

Backport of #38283 for the EGM regression, to be in synch with the online GTs, as requested in https://cms-talk.web.cern.ch/t/offline-gt-updating-egm-regression-tags-for-run-3-collisions-for-offline-tags/11203

The difference wrt the previous GTs are:
run3_data
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_v8/123X_dataRun3_v7

run3_data_relval
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts//123X_dataRun3_relval_v7/123X_dataRun3_relval_v6

PR validation:

runTheMatrix.py -l 136.897,139.001

if this PR is a backport please specify the original PR and why you need to backport that PR:

backport of #38283 for EGM.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

A new Pull Request was created by @malbouis for CMSSW_12_3_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@malbouis
Copy link
Contributor Author

malbouis commented Jun 9, 2022

please test

@malbouis
Copy link
Contributor Author

malbouis commented Jun 9, 2022

type egamma

@cmsbuild cmsbuild added the egamma label Jun 9, 2022
@malbouis
Copy link
Contributor Author

malbouis commented Jun 9, 2022

backport of #38283

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0810b6/25379/summary.html
COMMIT: 004ae86
CMSSW: CMSSW_12_3_X_2022-06-08-2300/slc7_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38295/25379/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3629068
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3629038
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 45 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jun 9, 2022

+alca

  • PR is according to the PR description
  • tests pass, no diffs are seen

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@malbouis
Copy link
Contributor Author

malbouis commented Jun 9, 2022

hold

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

Pull request has been put on hold by @malbouis
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added hold and removed fully-signed labels Jun 9, 2022
@malbouis
Copy link
Contributor Author

malbouis commented Jun 9, 2022

@malbouis malbouis closed this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants