Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport XML source file describing PPS pixel 2022 DAQ mapping to 12_4_X #38303

Merged
merged 1 commit into from Jun 10, 2022

Conversation

wpcarvalho
Copy link
Contributor

PR description:

This is a backport of #38150 which added the XML file containing the PPS DAQ mapping for 2022.

PR validation:

Not needed.

if this PR is a backport please specify the original PR and why you need to backport that PR:

Backport of #38150. It is not strictly needed, but PPS group finds it useful to have in the release the source DAQ mapping file which was used to build the latest DAQ mapping payload included in the online GTs for the same release cycle.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

A new Pull Request was created by @wpcarvalho (Wagner Carvalho) for CMSSW_12_4_X.

It involves the following packages:

  • CondFormats/PPSObjects (alca)

@cmsbuild, @malbouis, @tvami, @yuanchao, @francescobrivio can you please review it and eventually sign? Thanks.
@grzanka, @mmusich, @seemasharmafnal, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jun 9, 2022

type ctpps

@tvami
Copy link
Contributor

tvami commented Jun 9, 2022

@cmsbuild , please test

  • tho it's really just documentation

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d8a8d/25389/summary.html
COMMIT: 92764ed
CMSSW: CMSSW_12_4_X_2022-06-09-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38303/25389/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3671977
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3671935
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

malbouis commented Jun 9, 2022

+alca

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2022

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@tvami
Copy link
Contributor

tvami commented Jun 9, 2022

backport of #38150

@qliphy
Copy link
Contributor

qliphy commented Jun 10, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants