Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add XiMinus gen fragment for BPH validation #38390

Closed
wants to merge 2 commits into from

Conversation

mtosi
Copy link
Contributor

@mtosi mtosi commented Jun 16, 2022

PR description:

this PR adds the XiMinus genFragment in order to have this process in the relval matrix as well

the TuneCP5 is used, and the filter efficiency (thanks to @AdrianoDee) is the following
Before Filter: total cross section = 7.893e+10 +- 6.065e+01 pb
== CMSSW: Filter efficiency (taking into account weights)= (487) / (25000) = 1.948e-02 +- 8.741e-04
== CMSSW: Filter efficiency (event-level)= (487) / (25000) = 1.948e-02 +- 8.741e-04 [TO BE USED IN MCM]

I'm going to prepare the backport in 12_4_X as well

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38390/30587

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mtosi (mia tosi) for master.

It involves the following packages:

  • Configuration/Generator (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6620f1/25566/summary.html
COMMIT: 6e6c352
CMSSW: CMSSW_12_5_X_2022-06-15-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38390/25566/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659074
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3659044
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@mtosi
Copy link
Contributor Author

mtosi commented Jun 17, 2022

this genFragment could be useful for the upcoming validation of the "rollback of the pixelles tracking to CKF"

@SiewYan
Copy link
Contributor

SiewYan commented Jun 20, 2022

@mtosi , will a new PR on relval matrix pertaining this workflow be done in the future in conjunction with this PR? I could not find any existing test result on the gen fragment.

@AdrianoDee
Copy link
Contributor

@mtosi , will a new PR on relval matrix pertaining this workflow be done in the future in conjunction with this PR? I could not find any existing test result on the gen fragment.

Hi @SiewYan, yes that's the idea. Shall we have this first in or you would prefer to have the matrix wf PR in parallel?

@SiewYan
Copy link
Contributor

SiewYan commented Jun 20, 2022

Hello @AdrianoDee , I am fine to have this in for now. Please mention this PR in the upcoming PR on relval matrix. Thanks!

@Saptaparna , @GurpreetSinghChahal, @menglu21 can sign this shortly (also the backport), if they are fine with it.

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

Just to be sure: this fragment is identical to the one in XiMinus_14TeV_SoftQCDInel_TuneCP5_cfi.py, with as only differences

  • The MinPt at 1.0 GeV instead of 1.3 GeV
  • The crossSection parameter commented out

Is this intended?

The cms energy at 14 TeV is also intended for the validation of the "rollback of the pixelles tracking to CKF"?

@AdrianoDee
Copy link
Contributor

Indeed you are right. We would propose then to modify the existing fragment (see #38466 and #38467) closing this PR.

@perrotta
Copy link
Contributor

hold
@cms-sw/generators-l2 @mtosi @AdrianoDee please decide the strategy and remain with only one PR, which is the agreed one

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @perrotta
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@SiewYan
Copy link
Contributor

SiewYan commented Jun 23, 2022

@AdrianoDee , pleas feel free to close this PR in favor of #38466 and #38467

@perrotta
Copy link
Contributor

@AdrianoDee , pleas feel free to close this PR in favor of #38466 and #38467

@mtosi

@AdrianoDee
Copy link
Contributor

@perrotta, @mtosi is on holiday this week. Could you close it for us?

@perrotta
Copy link
Contributor

See #38390 (comment)

@perrotta perrotta closed this Jun 23, 2022
@AdrianoDee
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants