Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update XiMinus_14TeV_SoftQCDInel_TuneCP5 config #38466

Merged
merged 1 commit into from Jun 26, 2022

Conversation

AdrianoDee
Copy link
Contributor

@AdrianoDee AdrianoDee commented Jun 22, 2022

No validation needed. In a next PR a wf in the matrix will be added to test this for possible RelVal production.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38466/30678

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AdrianoDee for master.

It involves the following packages:

  • Configuration/Generator (generators)

@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@perrotta
Copy link
Contributor

Why this PR has "14TeV" in the name, if the CMS energy is not 14TeV any more?

Could you please explain the need of having both this and #38390?

For the sake of clarity, could a single PR add coherently all new configs needed, with some explanation for the apparent duplicates?

@AdrianoDee
Copy link
Contributor Author

Why this PR has "14TeV" in the name, if the CMS energy is not 14TeV any more?

About this, I don't know the policy (given this is the only fragment, as far as I see, with this kind of energy) so I was waiting for some feedback. I can easily move to 13p6TeV.

For the sake of clarity, could a single PR add coherently all new configs needed, with some explanation for the apparent duplicates?

Please, see #38390 (comment) where I explain exactly this. #38390 could be closed.

@AdrianoDee
Copy link
Contributor Author

AdrianoDee commented Jun 22, 2022

Let me add that the different energy is selected in order to be more adherent to the actual data taking conditions given this sample is mainly intended for checking tracking efficiency for displaced topologies of interest for the BPH (in the short term the pixelLess issue with mkFit).

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8dbb1/25696/summary.html
COMMIT: bfd4723
CMSSW: CMSSW_12_5_X_2022-06-22-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38466/25696/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659099
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3659069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@jordan-martins
Copy link
Contributor

we should keep consistency between the name and energy (14TeV -> 13p6TeV)

- lowering `pT` thresholds. Enhance gen efficiency (from 1 to 2 %).
- moving to `13.6 TeV`.
- renaming accordingly
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38466/30715

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

Pull request #38466 was updated. @SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @GurpreetSinghChahal, @alberto-sanchez can you please check and sign again.

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b8dbb1/25751/summary.html
COMMIT: 8bbe2ae
CMSSW: CMSSW_12_5_X_2022-06-23-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38466/25751/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659307
  • DQMHistoTests: Total failures: 13
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3659271
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Jun 26, 2022

@cms-sw/generators-l2 Any comment on this and the backported one #38467 ?

@Saptaparna
Copy link
Contributor

Saptaparna commented Jun 26, 2022

Hi @qliphy no comments as the change is quite minimal. Looks like one only the pT and the c.o.m energy was changed. Fine to merge. Thanks!

@Saptaparna
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants