Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added plots for 2/3 aligned ROCs per BX #38435

Merged

Conversation

AndreaBellora
Copy link
Contributor

@AndreaBellora AndreaBellora commented Jun 20, 2022

PR description:

Two more Online DQM plots added for the PPS pixels. These plots are necessary for the PPS alignment run (23/06/22).
The added plots follow a similar implementation to an already existing one, just with different parameters.

PR validation:

This PR can be validated by running a DQM playback of Run 354054 (currently ongoing). No additional validation is needed, the implementation is almost identical to code that is already implemented.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38435/30637

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @AndreaBellora for master.

It involves the following packages:

  • DQM/CTPPS (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @jfernan2, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@fabferro, @grzanka this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@AndreaBellora AndreaBellora marked this pull request as ready for review June 20, 2022 11:18
@emanueleusai
Copy link
Member

please test

@perrotta
Copy link
Contributor

@AndreaBellora I see that you opened a backport PR for 12_3_X
Please also open one for 12_4_X, so that the plots will remain available also for the remaining data taking periods of this 2022

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-14e24e/25679/summary.html
COMMIT: 99c28b3
CMSSW: CMSSW_12_5_X_2022-06-21-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38435/25679/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3659099
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3659069
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 49 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jun 22, 2022

+1

@cmsbuild cmsbuild merged commit 5e17661 into cms-sw:master Jun 22, 2022
AndreaBellora added a commit to AndreaBellora/cmssw that referenced this pull request Jun 22, 2022
cmsbuild added a commit that referenced this pull request Jun 22, 2022
…_dqmonline_backport

Added plots for 2/3 aligned ROCs per BX, backport of PR #38435
cmsbuild added a commit that referenced this pull request Jun 25, 2022
…ine_backport

Added plots for 2/3 aligned ROCs per BX, backport of PR #38435
kakwok pushed a commit to kakwok/cmssw that referenced this pull request Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants