Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DNS servers for BeamSpot DIP publication #38611

Merged
merged 1 commit into from Jul 7, 2022

Conversation

francescobrivio
Copy link
Contributor

PR description:

It was noticed during Fills 7920 and 7921 that the BeamSpot information wasn't being published on DIP.
Following the discussion in https://its.cern.ch/jira/browse/CMSOMS-280 it seems that

We're using redundant peers, and sometimes dns run in 1 and sometimes in 2, depending which of them is active

So both DNS addresses should be used in order to establish a connection.
This PR udpated both flavors of the BeamSpot DIP publisher: the DQM client (currently in production) and the standalone version (to be put in production soon).

PR validation:

Code compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, but 12_4_X and 12_3_X backports will be provided soon.

FYI: @sikler @gennai @dzuolo @amassiro

@francescobrivio
Copy link
Contributor Author

type bug-fix

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38611/30893

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @ahmad3213, @tvami, @jfernan2, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2022

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42a4c6/26003/summary.html
COMMIT: 3aadd93
CMSSW: CMSSW_12_5_X_2022-07-06-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38611/26003/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 50
  • DQMHistoTests: Total histograms compared: 3654771
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3654741
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
  • Checked 208 log files, 45 edm output root files, 50 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jul 7, 2022

+db

  • this was used yesterday night at P5

@francescobrivio
Copy link
Contributor Author

Just for reference, during tonight's stable beams (Fill 7923) the beamspot values were correctly published in DIP and subsequently picked up by OMS, see the attached screenshot:
Schermata 2022-07-07 alle 11 54 22

@francescobrivio
Copy link
Contributor Author

@cms-sw/dqm-l2 feel free to sign this at your convenience

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2022

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2022

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants