Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem geometry customs update #3885

Merged
merged 1 commit into from May 19, 2014
Merged

Gem geometry customs update #3885

merged 1 commit into from May 19, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented May 15, 2014

To be included after #3776

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

Gem geometry customs update

It involves the following packages:

Geometry/GEMGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented May 15, 2014

@dildick - after #3887 is in IB these customizations will not work - v3 directory is not there any more. There are PhaseII - with ME0 and PhaseII/NoME0 - without ME0.

@ianna
Copy link
Contributor

ianna commented May 15, 2014

+1

@dildick - I take it back. GEM directories are still ok.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @andersonjacob, @mark-grimes can you please take care of it?

@andersonjacob
Copy link
Contributor

Tested along with #3907

No problems.

passing
10000
10200
10400
11200
11400
12000
12800
13000
13600
14600

known failing
12200 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
12400 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
12600 Step0-PASSED 0 Step1-FAILED 34304 Step2-NOTRUN 0 Step3-NOTRUN 0
13800 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
14000 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
14200 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0
14400 Step0-PASSED 0 Step1-PASSED 0 Step2-FAILED 34304 Step3-NOTRUN 0

@andersonjacob
Copy link
Contributor

merge

cmsbuild added a commit that referenced this pull request May 19, 2014
@cmsbuild cmsbuild merged commit 5cd9f17 into cms-sw:CMSSW_6_2_X_SLHC May 19, 2014
@dildick dildick deleted the gem-geometry-customs-update branch April 30, 2016 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants