Adding missing scripts for ECAL TPG double weights + unit tests

[valsdav]

Two scripts were missing in the CondDB utilities for the ECAL TPG double weights code

• updateTPGOddWeightIdMap.py
• updateTPGOddWeightGroup.py

The scripts are used to convert ECAL TPG txt config files to CondDB tags to be used in the emulator for private studies or uploaded in the global tag.

Added unit tests for Ecal TPG weights mapping scripts.

This PR has no side effects.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38856/31261

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @valsdav (Davide Valsecchi) for master.

It involves the following packages:

• CondTools/Ecal (db)

@cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @qliphy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

@valsdav I understand these files are run manually to create the tags from the txt config files, but are there any unitTests already in place that test these scripts?

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5dc18/26446/summary.html
COMMIT: 2413333
CMSSW: CMSSW_12_5_X_2022-07-25-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/38856/26446/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3667670
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3667646
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

but are there any unitTests already in place that test these scripts?

If none, can you please make them?

[tvami]

@valsdav just to clarify: we are waiting for the introduction of the unit tests before merging this PR

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38856/31306

• This PR adds an extra 92KB to repository

[cmsbuild]

Pull request #38856 was updated. @cmsbuild, @ggovi, @tvami, @malbouis, @francescobrivio can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-38856/31380

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #38856 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

[francescobrivio]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5dc18/26591/summary.html
COMMIT: 094d4ba
CMSSW: CMSSW_12_5_X_2022-08-01-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/38856/26591/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
1042.0 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3669004
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3668974
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 210 log files, 47 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[tvami]

+db

• newly introduced unit tests pass https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b5dc18/26591/unitTests/success.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[makortel]

The EcalTPG_updateWeightGroup_test and EcalTPG_updateWeightIdMap_tests fail randomly in IBs, see #38964